From owner-freebsd-current Sat Apr 24 10:56:38 1999 Delivered-To: freebsd-current@freebsd.org Received: from herring.nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (Postfix) with ESMTP id 2F99C15168 for ; Sat, 24 Apr 1999 10:56:24 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from localhost (dfr@localhost) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id TAA29767; Sat, 24 Apr 1999 19:02:16 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Sat, 24 Apr 1999 19:02:15 +0100 (BST) From: Doug Rabson To: KATO Takenori Cc: peter@netplex.com.au, current@freebsd.org Subject: Re: singed short to unsigned long conversion problem in isa.c In-Reply-To: <19990425003653V.kato@gneiss.eps.nagoya-u.ac.jp> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 25 Apr 1999, KATO Takenori wrote: > Doug Rabson wrote: > > > It needs to be signed since the value -1 is used to indicate no port > > resources. Perhaps it would be better to change it to 'int' instead of > > 'u_short'. > > Oops, I didn't realize this case. > > The assumption that an I/O port address is lower than 0x8000 is OK for > IBM-PC's ISA-bus, but PC98 can use hiher addresses for ISA-bus like > bus. I understand. I think the best thing is to store the port address as an int. I don't think there is a need to fork the file into a pc98 version. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message