From owner-freebsd-current Mon Jul 8 12:27:57 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFFE537B400 for ; Mon, 8 Jul 2002 12:27:53 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E3A843E58 for ; Mon, 8 Jul 2002 12:27:53 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 591 invoked from network); 8 Jul 2002 19:27:51 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 8 Jul 2002 19:27:51 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g68JRof05224; Mon, 8 Jul 2002 15:27:50 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020708062855.02DE03808@overcee.wemm.org> Date: Mon, 08 Jul 2002 15:27:56 -0400 (EDT) From: John Baldwin To: Peter Wemm Subject: RE: Remember my ill-fated i386 smp pmap optimizations? Cc: current@freebsd.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 08-Jul-2002 Peter Wemm wrote: > A few months ago, I had a bit of a disaster with some pmap optimizations. > After committing, all hell broke loose. It was backed out completely. > > I finally found the problem (diff cleaned up to highlight the problem): > > pmap_mapdev() > ... > for (tmpva = va; size > 0; ) { > pte = vtopte(tmpva); > *pte = pa | PG_RW | PG_V | pgeflag; > size -= PAGE_SIZE; > tmpva += PAGE_SIZE; > - pa += PAGE_SIZE; > } > invltlb(); > > Excuse me while I go outside and shoot myself. Hahahaha! Glad to see you have fixed them. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message