From owner-svn-ports-all@freebsd.org Sun Sep 30 16:47:50 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7AFF10976F5; Sun, 30 Sep 2018 16:47:49 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 77C9E89EFA; Sun, 30 Sep 2018 16:47:49 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: by mail-ua1-f44.google.com with SMTP id 19so344355uas.13; Sun, 30 Sep 2018 09:47:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tfND9B8wlZmayUoFURygvUR1DRfE1XHi4O2RoYLwjkE=; b=iA7KO0bQoTbAD5mpwO9AXLb6dN/iyVlnhRLwtg7XqIx1Pta4r4N2FDvvkgDnh/8G7K xW+6QKjuCgQlKbRHVPv9lgj3f1yetnOqaSfh4sclefeW0UhFPEHP1lBDcK4LccYssKoL LcnQEVunPRj7PHSSm5JcR2iI2ZKYKI+CXvYoPGt4e8m97NdG7JxAyk5xzASQKyofaVnS vS7KBfZrMMda//ua68dOlZ8Qo/iaglTzZBfzOuXP3MALQTm6grXVNhbybETIg5hUgiE9 XckcBO3oPzuAtr7Ahfntsp+27NgMSV3QvC9koVqEaCSSyhRw/6+g4CAu2jpzzHdJapLY KxyQ== X-Gm-Message-State: ABuFfohqv28twFKzx63KyGLclQABb4Bqwk+pRvG2WNtX0tmXGbeUwOEx qvdKR3lF8XpAKdhe6ftH4At5MH/lWgUVjW+EWHmSwfnn X-Google-Smtp-Source: ACcGV60foRDZ8zxKrqvIdLbz5KV14k4tV8YpT89GGKrDo/LmFBC3XfKzgUZKxOdz8z5+/STORSBnyXFoF+t5UkfGNkE= X-Received: by 2002:a9f:3155:: with SMTP id n21-v6mr3028736uab.131.1538326062742; Sun, 30 Sep 2018 09:47:42 -0700 (PDT) MIME-Version: 1.0 References: <201809291950.w8TJoxrM093616@repo.freebsd.org> In-Reply-To: <201809291950.w8TJoxrM093616@repo.freebsd.org> From: "Jason E. Hale" Date: Sun, 30 Sep 2018 12:47:31 -0400 Message-ID: Subject: Re: svn commit: r480915 - in head/comms: . apitran To: db@freebsd.org Cc: ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2018 16:47:50 -0000 On Sat, Sep 29, 2018 at 3:51 PM Diane Bruce wrote: > > Author: db > Date: Sat Sep 29 19:50:58 2018 > New Revision: 480915 > URL: https://svnweb.freebsd.org/changeset/ports/480915 > > Log: > A Linux toolkit for handling signals over the automatric picture > transmission (APT) protocol. > > ## Intro to Automatic Picture Transmission > Automatic picture transmission (APT) is an analog image transmission format > developed for use on weather satellites in the 1960s. While only three > modern satellites, NOAA 15, NOAA 18, and NOAA 19, transmit on the APT > protocol, building a reception station is cheap and simple. The images can > be quite high qualitythey natively have a resolution of > 4 km/px. It is reasonable to expect at least one good-quality satellite > pass (and, thereby, opportunity for image downlink) per day. > > WWW: https://github.com/rsj56/apitran > > Added: > head/comms/apitran/ > head/comms/apitran/Makefile (contents, props changed) > head/comms/apitran/distinfo (contents, props changed) > head/comms/apitran/pkg-descr (contents, props changed) > head/comms/apitran/pkg-plist (contents, props changed) > Modified: > head/comms/Makefile > > Modified: head/comms/Makefile > ============================================================================== > --- head/comms/Makefile Sat Sep 29 19:09:29 2018 (r480914) > +++ head/comms/Makefile Sat Sep 29 19:50:58 2018 (r480915) > @@ -8,6 +8,7 @@ > SUBDIR += aldo > SUBDIR += amtterm > SUBDIR += anyremote > + SUBDIR += apitran > SUBDIR += aprsd > SUBDIR += atslog > SUBDIR += bfhist > > Added: head/comms/apitran/Makefile > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/comms/apitran/Makefile Sat Sep 29 19:50:58 2018 (r480915) > @@ -0,0 +1,46 @@ > +# $FreeBSD$ > + > +PORTNAME= apitran > +PORTVERSION= g20180926 > +CATEGORIES= comms astro hamradio python > +PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > + > +MAINTAINER= hamradio@FreeBSD.org > +COMMENT= Toolkit to handle the automatic picture transmission protocol > + > +LICENSE= GPLv3 > +LICENSE_FILE= ${WRKSRC}/LICENSE > + > +BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}tkinter>0:x11-toolkits/py-tkinter@${PY_FLAVOR} \ > + ${PYTHON_PKGNAMEPREFIX}scipy>0:science/py-scipy@${PY_FLAVOR} \ > + ${PYTHON_PKGNAMEPREFIX}pillow>0:graphics/py-pillow@${PY_FLAVOR} \ > + ${PYNUMPY} These are all RUN_DEPENDS. Please whitespace align these, as well. > +RUN_DEPENDS= sox:audio/sox \ > + display:graphics/ImageMagick > + > +USES= python shebangfix python:run > +USE_GITHUB= yes > +GH_ACCOUNT= rsj56 > +GH_PROJECT= apitran > +GH_TAGNAME= d209347 > +#25379d9b681f434145fde9dbbdb3c5ae3 > +#GH_TAGNAME= d20934725379d9b681f434145fde9dbbdb3c5ae3 These commented out things should probably be removed. > + > +SHEBANG_FILES= apitran > +USE_PYTHON= autoplist autoplist can only be used with distutils and you already have a pkg-plist. Please remove. > + > +do-build: > + Remove empty do-build target and use NO_BUILD=yes instead. Also add NO_ARCH=yes. > +do-install: > + ${INSTALL_SCRIPT} ${WRKSRC}/apitran ${STAGEDIR}${PREFIX}/bin > + ${MKDIR} ${STAGEDIR}${DOCSDIR} > + cd ${WRKSRC} cd ${WRKSRC} Why? Please remove. > +.for f in NOAA_APT_Frame_Format.gif README.md > + ${INSTALL_DATA} ${WRKSRC}/$f ${STAGEDIR}${DOCSDIR} > + ${MKDIR} ${STAGEDIR}${EXAMPLESDIR} MKDIR should not be in the for loop. > +.endfor > +.for f in ex_1ch_11025.png ex_2ch_48000.png ex_2ch_48000.wav > + ${INSTALL_DATA} ${WRKSRC}/Examples/$f ${STAGEDIR}${EXAMPLESDIR} > +.endfor > + > +.include > > Added: head/comms/apitran/distinfo > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/comms/apitran/distinfo Sat Sep 29 19:50:58 2018 (r480915) > @@ -0,0 +1,3 @@ > +TIMESTAMP = 1538226743 > +SHA256 (rsj56-apitran-g20180926-d209347_GH0.tar.gz) = 65e2d90dd0077d3a837afaaed98b2f51fe2fceb074e15b9358381a8d61b785b6 > +SIZE (rsj56-apitran-g20180926-d209347_GH0.tar.gz) = 57106527 > > Added: head/comms/apitran/pkg-descr > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/comms/apitran/pkg-descr Sat Sep 29 19:50:58 2018 (r480915) > @@ -0,0 +1,13 @@ > +A Linux toolkit for handling signals over the automatric picture Typo: automatric -> automatic Should probably omit Linux reference > +transmission (APT) protocol. > + > +## Intro to Automatic Picture Transmission > +Automatic picture transmission (APT) is an analog image transmission format > +developed for use on weather satellites in the 1960s. While only three > +modern satellites, NOAA 15, NOAA 18, and NOAA 19, transmit on the APT > +protocol, building a reception station is cheap and simple. The images can > +be quite high qualitythey natively have a resolution of Typo: qualitythey -> quality; they > +4 km/px. It is reasonable to expect at least one good-quality satellite > +pass (and, thereby, opportunity for image downlink) per day. > + > +WWW: https://github.com/rsj56/apitran > > Added: head/comms/apitran/pkg-plist > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/comms/apitran/pkg-plist Sat Sep 29 19:50:58 2018 (r480915) > @@ -0,0 +1,6 @@ > +bin/apitran > +%%DOCSDIR%%/NOAA_APT_Frame_Format.gif > +%%DOCSDIR%%/README.md > +%%EXAMPLESDIR%%/ex_1ch_11025.png > +%%EXAMPLESDIR%%/ex_2ch_48000.png > +%%EXAMPLESDIR%%/ex_2ch_48000.wav > Maybe use PORTDOCS/PORTEXAMPLES macros in the Makefile and DOCS/EXAMPLES options. That wav file is 96 MB by itself and users with limited space may want a way to not install it. -Jason