From owner-svn-ports-all@FreeBSD.ORG  Wed Oct 30 17:19:39 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 1DAB7659;
 Wed, 30 Oct 2013 17:19:39 +0000 (UTC)
 (envelope-from nemysis@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 08C7323B5;
 Wed, 30 Oct 2013 17:19:39 +0000 (UTC)
Received: from nemysis4now (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with SMTP id r9UHJavu053570;
 Wed, 30 Oct 2013 17:19:36 GMT (envelope-from nemysis@FreeBSD.org)
Received: by nemysis4now (sSMTP sendmail emulation);
 Wed, 30 Oct 2013 18:19:34 +0100
Date: Wed, 30 Oct 2013 18:19:34 +0100
From: Rusmir Dusko <nemysis@FreeBSD.org>
To: Dmitry Marakasov <amdmi3@FreeBSD.org>
Subject: Re: svn commit: r332117 - head/graphics/py-pyglet
Message-ID: <20131030171934.GA1124@nemysis4now>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, nemysis@FreeBSD.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2013 17:19:39 -0000

> +OPTIONS_DEFINE=DOCS EXAMPLES
> +OPTIONS_DEFAULT=DOCS EXAMPLES

As per my understanding you wrecked OPTIONS_DEFAULTS,
please take a look at

http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html and

5.12.2.3. Default Options


This is incorrect as well

.if ${ARCH} != "i386"
IGNORE= crashes or doesn't work on !i386
.endif

Please take a look at

http://pyglet.org/

pyglet 1.2 alpha released. The major 1.2alpha1 release brings pyglet to Python 3.
Pyglet now also runs on 64-bit operating systems Linux, Windows and OS X.
The OS X layer switched to using Cocoa. There's also a load of bug fixes,
updates to the OpenGL wrappers and other minor new improvements.
Thanks to the pyglet community for all your effort in getting this release out.

Submitted by Richard on 13-July-2012.


Secondly, I dont think this is required

.include <bsd.port.options.mk>

as

.if ${PORT_OPTIONS:MDOCS}

or

.if ${PORT_OPTIONS:MEXAMPLES


This is incorrect as well

cd ${WRKSRC}/doc && ${COPYTREE_SHARE} \* ${STAGEDIR}${DOCSDIR}/
cd ${WRKSRC}/examples && ${COPYTREE_SHARE} \* ${STAGEDIR}${EXAMPLESDIR}/


Better is to use

@(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR})
@(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR})


Please take better look at ports/182517.


Best regards,
Rusmir Dusko