Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 19 Dec 2022 16:29:04 +0100
From:      Moin Rahman <bofh@freebsd.org>
To:        Renato Botelho <garga@FreeBSD.org>
Cc:        "ports-committers@freebsd.org" <ports-committers@FreeBSD.org>, "dev-commits-ports-all@freebsd.org" <dev-commits-ports-all@FreeBSD.org>, "dev-commits-ports-main@freebsd.org" <dev-commits-ports-main@FreeBSD.org>, portmgr <portmgr@freebsd.org>
Subject:   Re: git: 721e5776c957 - main - Mk/**tex.mk: Convert bsd.tex.mk to USES=tex
Message-ID:  <A45ABAEC-BB63-4BBF-A4A9-761C628B7620@freebsd.org>
In-Reply-To: <706F6533-8545-44DE-84DB-363E2F4DE628@freebsd.org>
References:  <202212191445.2BJEjAJ9012677@gitrepo.freebsd.org> <48d155ae-5afc-0b47-5e8f-ef1fe98e2e18@FreeBSD.org> <706F6533-8545-44DE-84DB-363E2F4DE628@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help 

--Apple-Mail=_9841338B-8B3F-4E34-BA30-A31248DDB675
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_1109EDAC-C037-469B-954B-08D16D5A3C3E"


--Apple-Mail=_1109EDAC-C037-469B-954B-08D16D5A3C3E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On Dec 19, 2022, at 4:20 PM, Moin Rahman <bofh@freebsd.org> wrote:
>=20
>=20
>=20
>> On Dec 19, 2022, at 4:06 PM, Renato Botelho <garga@FreeBSD.org> =
wrote:
>>=20
>> On 19/12/22 11:45, Muhammad Moinur Rahman wrote:
>>> index cf49b696640c..57a1c21cb16e 100644
>>> --- a/lang/mlton/Makefile
>>> +++ b/lang/mlton/Makefile
>>> @@ -83,8 +83,9 @@ MAKE_ARGS=3D	DESTDIR=3D'' =
MLTON_VERSION=3D${PORTVERSION} \
>>> .if ${PORT_OPTIONS:MDOCS}
>>> BUILD_DEPENDS+=3D	htmldoc:textproc/htmldoc
>>> MAKE_ARGS+=3D	MLTON_BINARY_RELEASE_WITH_DOCS=3Dtrue
>>> -#USE_TEX=3D	latex:build
>>> -USE_TEX=3D	latex:formats
>>> +USES+=3D		tex
>>> +USE_TEX=3D	latex:build
>>> +#USE_TEX=3D	latex:formats
>>=20
>> This change seems wrong, it used to have latex:formats before and not =
it has latex:build.
>>=20
>> --
>> Renato Botelho
>>=20
>=20
> There was no keyword like <FORMAT>:formats in the previous bsd.tex.mk =
and neither there were any checks on the validity of the keywords. :v
>=20
> I think the descriptions are still a bit confusing and I need some =
help describing it more profoundly.
>=20
> In the file there is a description section formats and listing some =
tex formats which somehow uses the text like `formats:` and some formats =
but that colon is to list the separate formats not something like =
formats:<ARGS>. In addition to that there is in fact a keyword formats =
which also has a valid ARGS like test|build|run|extract|lib to mean the =
dependency on print/tex-formats rather than individual formats. In case =
it's required to have a dep on those listed formats the keyword of the =
name of the format should be used.
>=20
> I think I have been able to describe it properly but in case not feel =
free to advise if by anyhow I can improve the descriptions in the file.
>=20
> Kind regards,
> Moin
>=20

By the by in addition to those mentioned in case you are not happy with =
my explanation; I did check all the consumers(At least I tried my best; =
I might have missed one or two which I will fix in case I see them =
pkg-fallout) with the new infra and here are the result for this =
specific port:
https://pdr.bofh.network/data/latest-per-pkg/mlton/20210816/131-tex.log =
<https://pdr.bofh.network/data/latest-per-pkg/mlton/20210816/131-tex.log>;

Kind regards,
Moin


--Apple-Mail=_1109EDAC-C037-469B-954B-08D16D5A3C3E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=us-ascii

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br =
class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div =
class=3D"">On Dec 19, 2022, at 4:20 PM, Moin Rahman &lt;<a =
href=3D"mailto:bofh@freebsd.org" class=3D"">bofh@freebsd.org</a>&gt; =
wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div =
class=3D""><div class=3D"content-isolator__container"><br class=3D""><br =
class=3D""><blockquote type=3D"cite" class=3D"">On Dec 19, 2022, at 4:06 =
PM, Renato Botelho &lt;<a href=3D"mailto:garga@FreeBSD.org" =
class=3D"">garga@FreeBSD.org</a>&gt; wrote:<br class=3D""><br =
class=3D"">On 19/12/22 11:45, Muhammad Moinur Rahman wrote:<br =
class=3D""><blockquote type=3D"cite" class=3D"">index =
cf49b696640c..57a1c21cb16e 100644<br class=3D"">--- =
a/lang/mlton/Makefile<br class=3D"">+++ b/lang/mlton/Makefile<br =
class=3D"">@@ -83,8 +83,9 @@ MAKE_ARGS=3D<span class=3D"Apple-tab-span" =
style=3D"white-space:pre">	</span>DESTDIR=3D'' =
MLTON_VERSION=3D${PORTVERSION} \<br class=3D""> .if =
${PORT_OPTIONS:MDOCS}<br class=3D""> BUILD_DEPENDS+=3D<span =
class=3D"Apple-tab-span" style=3D"white-space:pre">	=
</span>htmldoc:textproc/htmldoc<br class=3D""> MAKE_ARGS+=3D<span =
class=3D"Apple-tab-span" style=3D"white-space:pre">	=
</span>MLTON_BINARY_RELEASE_WITH_DOCS=3Dtrue<br class=3D"">-#USE_TEX=3D<sp=
an class=3D"Apple-tab-span" style=3D"white-space:pre">	=
</span>latex:build<br class=3D"">-USE_TEX=3D<span class=3D"Apple-tab-span"=
 style=3D"white-space:pre">	</span>latex:formats<br =
class=3D"">+USES+=3D<span class=3D"Apple-tab-span" =
style=3D"white-space:pre">	</span><span class=3D"Apple-tab-span" =
style=3D"white-space:pre">	</span>tex<br class=3D"">+USE_TEX=3D<span =
class=3D"Apple-tab-span" style=3D"white-space:pre">	=
</span>latex:build<br class=3D"">+#USE_TEX=3D<span =
class=3D"Apple-tab-span" style=3D"white-space:pre">	=
</span>latex:formats<br class=3D""></blockquote><br class=3D"">This =
change seems wrong, it used to have latex:formats before and not it has =
latex:build.<br class=3D""><br class=3D"">--<br class=3D"">Renato =
Botelho<br class=3D""><br class=3D""></blockquote><br class=3D"">There =
was no keyword like &lt;FORMAT&gt;:formats in the previous bsd.tex.mk =
and neither there were any checks on the validity of the keywords. :v<br =
class=3D""><br class=3D"">I think the descriptions are still a bit =
confusing and I need some help describing it more profoundly.<br =
class=3D""><br class=3D"">In the file there is a description section =
formats and listing some tex formats which somehow uses the text like =
`formats:` and some formats but that colon is to list the separate =
formats not something like formats:&lt;ARGS&gt;. In addition to that =
there is in fact a keyword formats which also has a valid ARGS like =
test|build|run|extract|lib to mean the dependency on print/tex-formats =
rather than individual formats. In case it's required to have a dep on =
those listed formats the keyword of the name of the format should be =
used.<br class=3D""><br class=3D"">I think I have been able to describe =
it properly but in case not feel free to advise if by anyhow I can =
improve the descriptions in the file.<br class=3D""><br class=3D"">Kind =
regards,<br class=3D"">Moin<br class=3D""><br =
class=3D""></div></div></div></blockquote><br class=3D""></div><div>By =
the by in addition to those mentioned in case you are not happy with my =
explanation; I did check all the consumers(At least I tried my best; I =
might have missed one or two which I will fix in case I see them =
pkg-fallout) with the new infra and here are the result for this =
specific port:</div><div><a =
href=3D"https://pdr.bofh.network/data/latest-per-pkg/mlton/20210816/131-te=
x.log" =
class=3D"">https://pdr.bofh.network/data/latest-per-pkg/mlton/20210816/131=
-tex.log</a></div><div><br class=3D""></div><div>Kind =
regards,</div><div>Moin</div><br class=3D""></body></html>=

--Apple-Mail=_1109EDAC-C037-469B-954B-08D16D5A3C3E--

--Apple-Mail=_9841338B-8B3F-4E34-BA30-A31248DDB675
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmOgg0BfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE
Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA
vJG3YQ//c9jc03kLVnOadBABj+7LNSDJlv0MWTkyo1Ntv8VVXb9BMecWNQIUM2gB
xeH0T5aXhKceEhzrIrzPItcyORBzF/ixEcQ1SmhaXWr3p77W2+KcCkZ7vG7m41EF
H95vDG2jW0UpwiAq8ZkuzgSmX3Xjq4J02kg92u34TSo/S6rJF4NjYWVJPg9hvs+j
Ww5k33R9REtd6HlvN9t3TqrxNbyRd4XQuJZfh+HofSFCq4XdXO5uUdpr321v7eFE
i7Gla90RmOlLVwp8ov68qYFNzSq+EvCD49jQ2HZBcw3k/dzDVKPwvym0x4HcP9um
WkedSlTpukS/PxPaEeUyAqjRvnhblT17PtXTGmjiL5JU8uCJXCfEp04EuTzT89J+
lromQ5pGuSBFsZF+SlSEcalihSCm4yNaicNB6Op/7oRNZ9POzwgsQQF7YwnTnQHI
ay9sgWGRXIn0rsSrHuOo4MMCYDq7zw1xWvRzp7fN+PQSmW48c2sDB7FBXorW2UW9
jcxUExfjHS62h2TNXgret/gvl81jsEeYS8i772xW+Agv1bom0tLnwy1iw9ACuPTP
4ur1geqPxuwK9sEBt/33orPusjG2Y6GkRh93ts1WcQasxmRNlvHekNb7rXI+P1gK
LzBBRQu5w6HdINBAPFYiXJkaewUHjd3U/NsSF8ll6ygbYc+SowA=
=fK5b
-----END PGP SIGNATURE-----

--Apple-Mail=_9841338B-8B3F-4E34-BA30-A31248DDB675--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A45ABAEC-BB63-4BBF-A4A9-761C628B7620>