From owner-freebsd-bugs Mon Jun 28 10: 0: 4 1999 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 0BD8615372 for ; Mon, 28 Jun 1999 10:00:01 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id KAA25209; Mon, 28 Jun 1999 10:00:01 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from miva004.simplenet.net (unknown [209.132.1.204]) by hub.freebsd.org (Postfix) with ESMTP id 6879914E12 for ; Mon, 28 Jun 1999 09:50:39 -0700 (PDT) (envelope-from doug@miva004.simplenet.net) Received: (from doug@localhost) by miva004.simplenet.net (8.9.3/8.9.3) id SAA00349; Tue, 15 Jun 1999 18:27:02 -0700 (PDT) (envelope-from doug) Message-Id: <199906160127.SAA00349@miva004.simplenet.net> Date: Tue, 15 Jun 1999 18:27:02 -0700 (PDT) From: Studded@gorean.org Reply-To: Studded@gorean.org To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.2 Subject: conf/12432: empty amd_flags causes start failure in rc.network Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Number: 12432 >Category: conf >Synopsis: empty amd_flags causes start failure in rc.network >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jun 28 10:00:00 PDT 1999 >Closed-Date: >Last-Modified: >Originator: Doug >Release: FreeBSD 3.2-19990609-STABLE i386 >Organization: AAAG >Environment: 3.2-Stable with amd enabled in /etc/rc.conf[.local] >Description: With the following in /etc/rc.conf.local: amd_enable="YES" amd_flags="" amd_map_program="NO" The daemon is not started by rc.network. When a trivial flag is added (like "-F /etc/amd.conf") all works as advertised. >How-To-Repeat: See above. 100% repeatable. >Fix: Looking at the shell script I'm not sure exactly why it's not working. Everything seems above board, but the problem is verifiable. I can start it from the command line with just 'amd' so the lack of flags is not a problem. Also, there are some style nits in rc.network. The biggest one is that there are a number of tests like this: if [ "X$conf_option" -eq X"YES" ]; ... where the RHS should be "XYES" if you're going to use that style. On some versions of sh "XYES" does not equal X"YES" but on ours it seems to work anyway. Of course, all the rc scripts should be changed to use case anyway, but that's another PR. :) Sorry I don't have a fix, but I felt this should be documented in any case. Doug >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message