Date: Mon, 13 Jan 2020 11:31:01 -0700 From: Ian Lepore <ian@freebsd.org> To: Toomas Soome <tsoome@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib Message-ID: <5a3e388ed5c91a6d1f88ecc91c08dc103d0369d1.camel@freebsd.org> In-Reply-To: <202001131822.00DIMtrW016338@repo.freebsd.org> References: <202001131822.00DIMtrW016338@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2020-01-13 at 18:22 +0000, Toomas Soome wrote: > Author: tsoome > Date: Mon Jan 13 18:22:54 2020 > New Revision: 356693 > URL: https://svnweb.freebsd.org/changeset/base/356693 > > Log: > loader: allocate properly aligned buffer for network packet > > Use memalign(4, size) to ensure we have properly aligned buffer. > > MFC after: 2 weeks > > Modified: > head/stand/efi/libefi/efinet.c > head/stand/i386/libi386/pxe.c > head/stand/libofw/ofw_net.c > head/stand/uboot/lib/net.c > The malloc implementation in libstand already g'tees minimum alignment of 16 bytes on most arches, 64 bytes on arches that use u-boot (see libsa/zalloc_defs.h). So how does this change anything? -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5a3e388ed5c91a6d1f88ecc91c08dc103d0369d1.camel>