Date: Fri, 18 Oct 2013 16:28:19 +0000 From: Max Brazhnikov <makc@freebsd.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r330501 - head/deskutils/qrfcview Message-ID: <5760775.4keyzDQcE0@mercury.ph.man.ac.uk> In-Reply-To: <20131017192256.GG62015@hades.panopticon> References: <201310161249.r9GCnSFP011838@svn.freebsd.org> <1651195.G2FJH9mVfi@mercury.ph.man.ac.uk> <20131017192256.GG62015@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 17 Oct 2013 23:22:56 +0400 Dmitry Marakasov wrote: > * Max Brazhnikov (makc@freebsd.org) wrote: > > > I suppose your c++ is actually g++ > > It may be, it may be not. Anyway, if g++ shows itself in the build, > compiler is not respected. Another example: > > % CC="ccache cc" CXX="ccache c++" make all clean 2>&1 | grep -- -c | head -1 > g++ -c -O2 -pipe -march=nocona ... > > with my qmake.mk patch: > > % CC="ccache cc" CXX="ccache c++" make all clean 2>&1 | grep -- -c | head -1 > ccache c++ -c -O2 -pipe -march=nocona ... > > > > That's because QMAKEFLAGS contains QMAKE_CC and friends, but > > > QMAKE_ARGS from Uses/qmake.mk doesn't. > > > > it doesn't need to: compiler is already respected via QMAKESPEC, > > QMAKE_CC, etc are redundant. > > No, QMAKESPEC is just a bunch of hardcoded values - it respects nothing. QMAKESPEC is set in accordance with CXX value, but I see your point, so I propose the following patch http://people.freebsd.org/~makc/patches/bsd.qt.mk.diff btw, in case you have missed one of my previous mail, there is one more patch for you http://people.freebsd.org/~makc/patches/qnetwalk.diff Cheers, Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5760775.4keyzDQcE0>