From owner-freebsd-current@FreeBSD.ORG Sat Nov 23 08:20:52 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 26B91A18 for ; Sat, 23 Nov 2013 08:20:52 +0000 (UTC) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com [209.85.215.49]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A64132BD2 for ; Sat, 23 Nov 2013 08:20:51 +0000 (UTC) Received: by mail-la0-f49.google.com with SMTP id er20so1567518lab.22 for ; Sat, 23 Nov 2013 00:20:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=b4Ic84DRZ/aA0XIqkrMbiPlAm7i+tGHn3Z114i1fDYM=; b=KLQs7PvXCLIdQF3MrPmWfog1nz/ITukqI+8M10dh1AjsFHnN75tQDxyt69c5FdY7M4 UkHkh2qRUByb0CjM6DWttasMwYLIHDjloj8Tf2b9U4z12MCtxhjVx2FFgoKIZaMFVPFu tSS6d6N1niowMRaM5LH+/qGmpg1EC/Zy9E8GWx8jsrdsvxFM4qxXNf+k0xyNFAVdSBM1 uNG7EyrWTvvPoJtWSmMsH7OQOzeWXkaogi/lcUVxZ7fHy3X/N1cE24pAXX1qSN6zzE8A SFwrJ3lXV4BJLIGnHSFITDYDd3+IMp4HWRVQ2B10etDGFXs4m7Us/qjeLLUIQt2Xe63y 2Evg== X-Gm-Message-State: ALoCoQlceKi05lj3cfErnZ+E/WKFBrAf7gS2pIBix9AI2Kk1nmdXvLzXhhEwuOcGNU/V1kXJPlSS X-Received: by 10.152.26.131 with SMTP id l3mr175619lag.29.1385194840265; Sat, 23 Nov 2013 00:20:40 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id sd11sm31397649lab.2.2013.11.23.00.20.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 23 Nov 2013 00:20:39 -0800 (PST) Message-ID: <52906558.2010604@freebsd.org> Date: Sat, 23 Nov 2013 12:20:40 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: ipfw build error with WITHOUT_PF (pfvar.h) References: <52906247.4030504@freebsd.org> <20131123081227.GD90895@glebius.int.ru> In-Reply-To: <20131123081227.GD90895@glebius.int.ru> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Nov 2013 08:20:52 -0000 On 23.11.2013 12:12, Gleb Smirnoff wrote: > Andrey, > > On Sat, Nov 23, 2013 at 12:07:35PM +0400, Andrey Chernov wrote: > A> There is a problem in recent -current to build ipfw with WITHOUT_PF > A> option, introduced in r257215. altq.c file produce error due to included > A> have following includes > A> > A> #include > A> #include > A> #include > A> > A> and netpfil/pf directory is empty in > A> /usr/src/include/Makefile with WITHOUT_PF option. > > The quick solution would be to make ipfw lose some functionality if > PF is cut away from system. > > The proper solution would be to make ALTQ configurable w/o pfctl. > How it was handled previously? F.e. ipfw in -stable 9 builds normally with WITHOUT_PF and have pfvar.h included too, but old pfvar.h have only which is available with WITHOUT_PF. By a first glance, alternative altq.c file with the same functions declared, but does nothing will be solution, replacing original when MK_PF is no.