From nobody Thu Nov 9 12:34:27 2023 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SR1cC0YCtz50hRD for ; Thu, 9 Nov 2023 12:34:35 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SR1cB5plnz4Zkj; Thu, 9 Nov 2023 12:34:34 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.17.1/8.17.1) with ESMTP id 3A9CYSnB028865; Thu, 9 Nov 2023 06:34:28 -0600 (CST) (envelope-from mike@karels.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karels.net; s=mail2; t=1699533268; bh=Lv3rcoFtqcT1KDnYodo0LwUEkb47RAdxe/RmsULg1xM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Panl4CXz9Qwvmv1lEI5YVOJk3fkjGZAMIgbJEt/3CKO4r2zBW25ihQFor8s9enecE JzCh40U5X+m+N0ishGR5pSeBWyzYrVzsB+DN5I9gWlgKlExfjP32iQeEP0FLzKKWnM SKujB2TmzsOcq6Pml2cRE6myKoijBb5siHvrxfvHpP3ol2kOvMSnO0h9h15FIllMAP 2vGQOV57g8rRFV/EKWqVf6XxEOsaSGKaMRa3XIKOnvFf6mvPmGD3rsgtMtXEQCGBrB tXuB/De+XYiOH2Lz5dNZHP/4SbroeoycP0mqOAe1DcJObnnQFzHR2IGRB/J+r7zaR3 EPbEF4c4YTQsA== Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id aOsLBdTRTGW/cAAAs/W3XQ (envelope-from ); Thu, 09 Nov 2023 06:34:28 -0600 From: Mike Karels To: Ronald Klop Cc: freebsd-net@freebsd.org Subject: Re: reviewers for if_smsc change? Date: Thu, 09 Nov 2023 06:34:27 -0600 X-Mailer: MailMate (1.14r5964) Message-ID: In-Reply-To: <8dedc456-56d4-4afe-b4ac-22c638922b49@FreeBSD.org> References: <141a8977-4622-41d0-9e6b-aaf2a942eacf@FreeBSD.org> <8dedc456-56d4-4afe-b4ac-22c638922b49@FreeBSD.org> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Rspamd-Queue-Id: 4SR1cB5plnz4Zkj On 9 Nov 2023, at 4:30, Ronald Klop wrote: > On 11/4/23 15:39, Ronald Klop wrote: >> Hi, >> >> For issue 274092 [1] I'm looking for reviewers. >> >> A user on the ML had an issue that the MAC address was not assigned on= some Raspberry PI compute modules. >> I tried and succeeded in using the MAC address passed on from the firm= ware to the kernel. >> >> The review is in: https://reviews.freebsd.org/D42463 >> >> I have a ports commit bit if possible I would like it to commit this m= yself as first steps in more in depth FreeBSD development. >> >> Regards, >> Ronald. >> >> >> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274092 (if_sms= c.c needs to use ether_gen_addr instead of read_random for more stable MA= C address) >> > > > Hi, > > I got some comments on the phabricator review and updated the patch wit= h it. I think it is pretty clean now and it is tested and works. > How should I go from here? > Can somebody help me commit this (I am a ports committer) or commit thi= s for me? > Do I need more approval and if yes, how can I get that? > > Regards, > Ronald. The change looks good to me now. I think it would be good if someone who= works on USB looked at it too. I am willing to approve the change; I thi= nk you can commit it with approval. Mike