Date: Thu, 09 Nov 2023 06:34:27 -0600 From: Mike Karels <mike@karels.net> To: Ronald Klop <ronald@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: Re: reviewers for if_smsc change? Message-ID: <CBD01739-52E7-41A5-BEBA-89BFECC6EA72@karels.net> In-Reply-To: <8dedc456-56d4-4afe-b4ac-22c638922b49@FreeBSD.org> References: <141a8977-4622-41d0-9e6b-aaf2a942eacf@FreeBSD.org> <8dedc456-56d4-4afe-b4ac-22c638922b49@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 Nov 2023, at 4:30, Ronald Klop wrote: > On 11/4/23 15:39, Ronald Klop wrote: >> Hi, >> >> For issue 274092 [1] I'm looking for reviewers. >> >> A user on the ML had an issue that the MAC address was not assigned on= some Raspberry PI compute modules. >> I tried and succeeded in using the MAC address passed on from the firm= ware to the kernel. >> >> The review is in: https://reviews.freebsd.org/D42463 >> >> I have a ports commit bit if possible I would like it to commit this m= yself as first steps in more in depth FreeBSD development. >> >> Regards, >> Ronald. >> >> >> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274092 (if_sms= c.c needs to use ether_gen_addr instead of read_random for more stable MA= C address) >> > > > Hi, > > I got some comments on the phabricator review and updated the patch wit= h it. I think it is pretty clean now and it is tested and works. > How should I go from here? > Can somebody help me commit this (I am a ports committer) or commit thi= s for me? > Do I need more approval and if yes, how can I get that? > > Regards, > Ronald. The change looks good to me now. I think it would be good if someone who= works on USB looked at it too. I am willing to approve the change; I thi= nk you can commit it with approval. Mike
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CBD01739-52E7-41A5-BEBA-89BFECC6EA72>