From nobody Sun Sep 21 10:46:44 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cV2x05s5zz67vZV; Sun, 21 Sep 2025 10:46:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cV2x03DvCz3X1H; Sun, 21 Sep 2025 10:46:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758451604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UPhcRYerKZ7germzRHJAWacrWX6HbaAM3BmV7Y3UtBs=; b=xFs6pHQfFLiBOetGzu2DoypqwkX3hibdvQfitWQu18yJsHhola7sokAhFNNHJ6SyDJRySL UoFtmLhl7s2k5HZBrpIZasaYD6C8Ow42EP00CFCY5eguUvBAYSmRQmIHtiEXTGMiuUWMq7 FtS7Vxt+oxBfaNtIe1p+Zh5JTW2ZVkqh9QtKm1BS/q+7kF5N1juqa0Bl4BC3ZH+8WdOYc4 Xk1/gqeD0kuUIsKMz9UmVb+WjLqMpAwm3PQYXfxhRgBvSIUqevapvL36ezaqkIKMcoiMna VsEWm2Ni9LyarUfF3CrlMX+TUjqaZJvTGN950aWko8HDCmsc1PRiv0+OMQJPOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758451604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UPhcRYerKZ7germzRHJAWacrWX6HbaAM3BmV7Y3UtBs=; b=aiWxXtk+1aQW5yc2jUcCUIu9KZ6Ju3tNu8Pac1wzdmVZH9fh2CEbtYuGDelXT7Drs1mt1y d3GPdZVC83F8GkZzA0jlHbRORmjCHTtgKy3giVKJjW/GCyBiymwJ6emmPrbQJ2eH7P/hC+ JJjH09vneKvzUQOqTjtZaRHt9gafDhwvAEyN5WmHfXFXRds57qnykPo2aPMjQ+zHDl9q/H /CLOJ7ii1ESBjUqzhUVVPN+ydARBpZ6mrGmZtYGl7IiYkR/7Wkqtr4EYrGAejm/LJP1yxF +2DB0aNFgazmtu7rlAtkR/n8iok8B6kJHXyFjyyFpmW4YvGjLcNsI0fQbaO2mg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758451604; a=rsa-sha256; cv=none; b=KuhfWCaugbUuxngGLmphfXNQaWiA1wTecocXOaF9oBlD5kqXwPbc2aDFVNme9zAqJpB9GR VrnZbOabuUN4K/JN7zupIJFi+QeZi7pIuQ/43uJytwRF9bf28aj6XZBmRqv+iDfVOYAB0Q h/sWBg9OwT3hVv6bpccGVee/5vGyRWTAaH+DVZ2w5kjHSJcO1XNx0JvrfXkvBpPlvPLfgh NJOwEIGUearSDoWizilU0QXEyqzL3eoC6TsfzoXaxSBy28RuvdtaWd7ps18sWC1X1qsNxR trs+PvscQrhgUOUV+ugrV7/e7ZXM1gjWEsAEKPYSZ/DjUlYZvToY3Idh4qlYNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cV2x02rfpz19Lq; Sun, 21 Sep 2025 10:46:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58LAkiW6051072; Sun, 21 Sep 2025 10:46:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58LAkiWD051069; Sun, 21 Sep 2025 10:46:44 GMT (envelope-from git) Date: Sun, 21 Sep 2025 10:46:44 GMT Message-Id: <202509211046.58LAkiWD051069@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: 7fcd41dfa6ee - stable/15 - gpioled: remove redundant -1 check List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 7fcd41dfa6ee3595d5263e8e298632c6317afb83 Auto-Submitted: auto-generated The branch stable/15 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=7fcd41dfa6ee3595d5263e8e298632c6317afb83 commit 7fcd41dfa6ee3595d5263e8e298632c6317afb83 Author: Ahmad Khalifa AuthorDate: 2025-09-18 22:03:32 +0000 Commit: Ahmad Khalifa CommitDate: 2025-09-21 10:03:14 +0000 gpioled: remove redundant -1 check The function is never called with onoff = -1 MFC after: 3 days MFC with: 9ae3c30 (cherry picked from commit e0c83ab3b362c9bd45c5d21683012cecab28d802) --- sys/dev/gpio/gpioled.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/gpio/gpioled.c b/sys/dev/gpio/gpioled.c index 71af5741b2fe..a36c2faef379 100644 --- a/sys/dev/gpio/gpioled.c +++ b/sys/dev/gpio/gpioled.c @@ -75,8 +75,6 @@ gpioled_control(void *priv, int onoff) struct gpioled_softc *sc; sc = (struct gpioled_softc *)priv; - if (onoff == -1) /* Keep the current state. */ - return; if (sc->sc_softinvert) onoff = !onoff; GPIOLED_LOCK(sc);