Date: Wed, 23 Sep 1998 14:43:20 +0300 (EEST) From: Adrian Penisoara <ady@warpnet.ro> To: Satoshi Asami <asami@FreeBSD.ORG> Cc: ports@FreeBSD.ORG, se@FreeBSD.ORG Subject: Re: fetch + size Message-ID: <Pine.BSF.3.96.980923143448.17833C-100000@ady.warpnet.ro> In-Reply-To: <199809230014.RAA09344@silvia.hip.berkeley.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Tue, 22 Sep 1998, Satoshi Asami wrote: > * > (2) The patch adds a SIZE line to files/md5. That is quite > * > displeasing aesthetically (there's a reason why the file was > * > called "md5" in the first place...) > * > * I don't see how a file with different size would have the same MD5 > * checksum !... > * Why should we need a SIZE line on top of the MD5 checksum ? > > Sorry, forgot to mention that too. The point is that if there is a > master site with a different file but with the same name, fetch can > (usually) tell right away that the size is wrong. On the other hand, > you will have to fetch the whole file to see that the checksum is > wrong (at which point the fetch loop will terminate with an error). OK, S.E. already explained me this and I like it now ! :) > > This will help in cases where there are multiple master sites and only > a few have the correct file. Then the new "fetch" will return an > error for size mismatch and bsd.port.mk will try to continue on a new > site. > > Stefan, did I get that right? AFAIK I believe you did. BTW, I have a proposition/question: why is it needed to recalculate the distfile's checksum for every "make" (f.e. if I do "make extract" and then "make" the distfile will be checked again -- I believe this isn't needed, if we get past the "extract" target there shouldn't be done any checksum checking anymore. I believe it wouldn't be too hard to code this into bsd.port.mk, probably checking for the .extract file in the "checksum" target ? > > Satoshi > thanks, Ady (@freebsd.ady.ro) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.980923143448.17833C-100000>