From owner-svn-src-head@FreeBSD.ORG  Sun Nov  1 16:15:21 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DEECB1065676;
	Sun,  1 Nov 2009 16:15:21 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id B95548FC13;
	Sun,  1 Nov 2009 16:15:21 +0000 (UTC)
Received: from [192.168.2.101] (host217-43-176-60.range217-43.btcentralplus.com
	[217.43.176.60])
	by cyrus.watson.org (Postfix) with ESMTPSA id BF2BB46B2A;
	Sun,  1 Nov 2009 11:15:20 -0500 (EST)
Mime-Version: 1.0 (Apple Message framework v1076)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
From: "Robert N. M. Watson" <rwatson@FreeBSD.org>
In-Reply-To: <20091101153339.GH1293@hoeg.nl>
Date: Sun, 1 Nov 2009 16:15:18 +0000
Content-Transfer-Encoding: 7bit
Message-Id: <D07678DD-D29E-4561-84AE-E969BE69BB42@FreeBSD.org>
References: <200910311035.n9VAZfIb082932@svn.freebsd.org>
	<alpine.BSF.2.00.0911011506130.2930@fledge.watson.org>
	<20091101153339.GH1293@hoeg.nl>
To: Ed Schouten <ed@80386.nl>
X-Mailer: Apple Mail (2.1076)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r198706 - head/sys/sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Nov 2009 16:15:22 -0000


On 1 Nov 2009, at 15:33, Ed Schouten wrote:

> Because d_kind is a pointer, there will be a hole in the structure  
> of at
> least 2 bytes (maybe even 6), which means we can safely extend  
> d_mode to
> 32 bits as well. I could have decided to leave it at uint16_t, but  
> that
> would only obfuscate it even more when we would try to reclaim some
> space there.
>
> d_list is just two pointers, so I merged it with d_kind into an  
> array of
> three pointers

No, you're right, and I was mistaken, it seems fine on i386 and amd64.  
And, at least here, d_devs is at the same offset on both  
architectures. The only really "weird" architecture is arm, which I  
believe aligns char and short to 32-bit, but that should be OK here I  
think as well.

Robert