Date: Thu, 08 Feb 2024 18:22:40 -0800 From: Chris <i.h8.git@BSDforge.com> To: Moin Rahman <bofh@freebsd.org> Cc: Daniel Engberg <diizzy@freebsd.org>, ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e2b4eb57621f - main - graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29 Message-ID: <3f345b530da18a497a7d25a2a9e202ed@BSDforge.com> In-Reply-To: <A3FF2AF8-CAD9-4D0D-AFDE-3E1FCABD613E@freebsd.org> References: <202402082211.418MBK2t091444@gitrepo.freebsd.org> <9b6a0d96cb2fe54d6702727c9b1d882e@BSDforge.com> <A3FF2AF8-CAD9-4D0D-AFDE-3E1FCABD613E@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2024-02-08 17:31, Moin Rahman wrote: >> On Feb 9, 2024, at 2:25 AM, Chris <i.h8.git@BSDforge.com> wrote: >> >> On 2024-02-08 14:11, Daniel Engberg wrote: >>> The branch main has been updated by diizzy: >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=e2b4eb57621f1c96f678c210fe7d2474c904e295 >>> commit e2b4eb57621f1c96f678c210fe7d2474c904e295 >>> Author: Daniel Engberg <diizzy@FreeBSD.org> >>> AuthorDate: 2024-02-08 22:08:52 +0000 >>> Commit: Daniel Engberg <diizzy@FreeBSD.org> >>> CommitDate: 2024-02-08 22:09:19 +0000 >>> graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29 >>> Fails to build with libpng 1.6.41 due to usage of undocumented feature >>> to >>> disable Adler32 checksums. >>> Last release in 2017 and dead upstream, redirect users to >>> graphics/oxipng >>> or graphics/pngquant >> This port is not broken. Please reverse this. >> If you, or anyone has an issue with the port. Use the bug reporting >> channel. >> That's what it is designed for. >> >>> Reference: >>> >>> https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5 >>> PR: 276649 >>> Reviewed by: Anton Saietskii <vsasjason@gmail.com> (maintainer) >>> --- >>> graphics/pngcrush/Makefile | 3 +++ >>> 1 file changed, 3 insertions(+) >>> diff --git a/graphics/pngcrush/Makefile b/graphics/pngcrush/Makefile >>> index 63e8ab2869d4..b38e9e664acc 100644 >>> --- a/graphics/pngcrush/Makefile >>> +++ b/graphics/pngcrush/Makefile >>> @@ -14,6 +14,9 @@ LICENSE_NAME= Pngcrush License >>> LICENSE_FILE= ${WRKSRC}/LICENSE >>> LICENSE_PERMS= dist-mirror pkg-mirror auto-accept >>> +BROKEN= Depends on undocumented feature to disable Adler32 checksums, >>> consider >>> graphics/oxipng or graphics/pngquant >>> +EXPIRATION_DATE=2024-02-29 >>> + >>> LIB_DEPENDS= libpng.so:graphics/png >>> USES= cpe localbase:ldflags tar:xz > > Do you have a log that it builds with the newest libpng? I'm on current, my ports tree is 5 days old. I built it before submitting this reply: fbsd15# make -DBATCH check-plist ===> License Pngcrush accepted by the user ===> pngcrush-1.8.13 depends on file: /usr/local/sbin/pkg - found => pngcrush-1.8.13-nolib.tar.xz doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch https://downloads.sourceforge.net/project/pmt/pngcrush/1.8.13/pngcrush-1.8.13-nolib.tar.xz pngcrush-1.8.13-nolib.tar.xz 64 kB 1076 kBps 00s ===> Fetching all distfiles required by pngcrush-1.8.13 for building ===> Extracting for pngcrush-1.8.13 => SHA256 Checksum OK for pngcrush-1.8.13-nolib.tar.xz. ===> Patching for pngcrush-1.8.13 ===> pngcrush-1.8.13 depends on shared library: libpng.so - found (/usr/local/lib/libpng.so) ===> Configuring for pngcrush-1.8.13 ===> Building for pngcrush-1.8.13 --- pngcrush.o --- touch png.h mv png.h png.h_embedded cc -c -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing pngcrush.c mv png.h_embedded png.h --- pngcrush --- cc -fstack-protector-strong -L/usr/local/lib -o pngcrush pngcrush.o -lpng -lz -lm ===> Staging for pngcrush-1.8.13 ===> Generating temporary packing list install -s -m 555 /usr/ports/graphics/pngcrush/work/pngcrush-1.8.13-nolib/pngcrush /usr/ports/graphics/pngcrush/work/stage/usr/local/bin/pngcrush ====> Compressing man pages (compress-man) ====> Running Q/A tests (stage-qa) Warning: you might not need LIB_DEPENDS on libpng.so ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) /usr/ports/graphics/pngcrush 5:05pm Thu, 08 fbsd15# Thanks. :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3f345b530da18a497a7d25a2a9e202ed>