From owner-dev-commits-src-all@freebsd.org  Sun Jan 10 09:27:08 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8EBBB4BDAB0;
 Sun, 10 Jan 2021 09:27:08 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DDBLh3019z3vdW;
 Sun, 10 Jan 2021 09:27:08 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2020.home.selasky.org (unknown [178.17.145.105])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id A94B72600DD;
 Sun, 10 Jan 2021 10:27:05 +0100 (CET)
Subject: Re: git: afd590d9e566 - main - hid: Import hidmap and bunch of
 drivers based on it
To: Ryan Libby <rlibby@freebsd.org>, Vladimir Kondratyev <wulf@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>,
 dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
References: <202101072320.107NKosW063030@gitrepo.freebsd.org>
 <CAHgpiFx0+9tOHjPv9yUbzNQdywxxUm3=FkqK3HBEnWJaOCVQxA@mail.gmail.com>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <d781282f-46ad-e55d-c4bc-7cd4a2b88b80@selasky.org>
Date: Sun, 10 Jan 2021 10:26:55 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <CAHgpiFx0+9tOHjPv9yUbzNQdywxxUm3=FkqK3HBEnWJaOCVQxA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4DDBLh3019z3vdW
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2021 09:27:08 -0000

On 1/10/21 7:39 AM, Ryan Libby wrote:
> This broke the gcc build in about a half dozen places due to -Wswitch,
> e.g. here.  If you like, I can prepare an inelegant patch adding
> either default cases or all the ignored cases to all of them.

wulf: I believe adding "default:" cases to all switch statements added 
in the patch series is the right thing to do.

--HPS