From owner-svn-ports-head@freebsd.org  Fri Nov  2 09:07:48 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E74A310EE80C;
 Fri,  2 Nov 2018 09:07:47 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E1147E3D3;
 Fri,  2 Nov 2018 09:07:47 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from atuin.in.mat.cc (unknown
 [IPv6:2a01:678:42:ffff:3e15:c2ff:fec4:452e])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: mat/mail)
 by smtp.freebsd.org (Postfix) with ESMTPSA id E30A31BD6D;
 Fri,  2 Nov 2018 09:07:46 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Date: Fri, 2 Nov 2018 10:07:44 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Mark Linimon <linimon@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r483758 - head/devel/libpru
Message-ID: <20181102090744.4f7mkmgjuxvrd776@atuin.in.mat.cc>
References: <201811020135.wA21ZqbL037253@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="ykvbjypibdhyxvj7"
Content-Disposition: inline
In-Reply-To: <201811020135.wA21ZqbL037253@repo.freebsd.org>
User-Agent: NeoMutt/20180716
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Nov 2018 09:07:48 -0000


--ykvbjypibdhyxvj7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 02, 2018 at 01:35:52AM +0000, Mark Linimon wrote:
> Author: linimon
> Date: Fri Nov  2 01:35:51 2018
> New Revision: 483758
> URL: https://svnweb.freebsd.org/changeset/ports/483758
>=20
> Log:
>   Fix build with GCC-based architectures.
>  =20
>   PR:		232851
>   Submitted by:	Piotr Kubaj
>=20
> Modified:
>   head/devel/libpru/Makefile
>=20
> Modified: head/devel/libpru/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/devel/libpru/Makefile	Fri Nov  2 01:34:15 2018	(r483757)
> +++ head/devel/libpru/Makefile	Fri Nov  2 01:35:51 2018	(r483758)
> @@ -11,13 +11,15 @@ COMMENT=3D	Library to interface with PRUs
>  LICENSE=3D	BSD2CLAUSE
> =20
>  IGNORE_DragonFly=3D	only supported on FreeBSD
> -BROKEN_mips=3D	Does not build: unrecognized command line option -Weveryt=
hing
> -BROKEN_mips64=3D	Does not build: unrecognized command line option -Wever=
ything
> -BROKEN_powerpc64=3D	Does not build: unrecognized command line option -We=
verything
> -BROKEN_sparc64=3D	Does not build: unrecognized command line option -Weve=
rything
> -
>  USES=3D		cmake
> =20
>  WRKSRC=3D		${WRKDIR}/rpaulo-libpru-5a74157b82b8
> =20
> -.include <bsd.port.mk>
> +.include <bsd.port.pre.mk>
> +
> +post-patch:
> +.if ${ARCH:Mmips*} || ${ARCH:Mpowerpc*} || ${ARCH} =3D=3D sparc64
> +	${REINPLACE_CMD} -e 's/ -Weverything//'  ${WRKSRC}/CMakeLists.txt
> +.endif
> +
> +.include <bsd.port.post.mk>

Could you try and put the whole target definition inside the if so that
it does not needlessly create an empty target, like this:


=2Eif ${ARCH:Mmips*} || ${ARCH:Mpowerpc*} || ${ARCH} =3D=3D sparc64
post-patch:
	${REINPLACE_CMD} -e 's/ -Weverything//'  ${WRKSRC}/CMakeLists.txt
=2Eendif

--=20
Mathieu Arnold

--ykvbjypibdhyxvj7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlvcE99fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkh7Ag/8CbytdirI7bOU82PCSa5SiOcOUHcSLmpXA+R0eKACMd9rPcttEF3g8nLJ
eDQOCjYbodQkzTcJzqbxYxESNf5dhI1EeORv36VbErj6qGVqwCj78x8K5PRStNpA
KFGK98JqXE20n9A3owrlF/4z4FaysJqFrUtOsKJkBJkhexWuVNr4HsqwZWI5G/Gb
STabqWtmK6hF8OaHNPyLCzr/8FXcd1JsiWPXTVv/CaaPGKWDIIABnXiY0iibAAXj
pmUP7MwxvPgat+rlc4EHTGl47EXCyfnrwYlesyyMBbMRZTKieWQhbG7qcN2wkV1Q
jCDe9mQ+jFFP/tmVu7wBln7AsFFI55rNwPFC/zwkPu5snMsjPxktYeOMtkrVW/AH
gaQ6OKmx1quM/Fo7fF8KT3YftdkUBeDIvQEMW0K3Ok5Kn+xwMISrTJPNr4IAdRHX
00L9iKZE6JwLXVXg97ZYe0ocUREpFFTKC1A4fxE7o+1YWp+DUXqkswrM9wFTGM2o
67jI0VgUz9zJ2soHC/wpxhtyZv/rAMYhv2Xo7FK7uK5qnOHyAmjIZvtUfwQmtGpo
wE5hxLFM5HcLvq100FWZZ3/UWhcBdtQSZ/mHQFUyKqnhuy0ywBb1trhB9H2yU89E
Tqh2092SfNlBp3eJSwXY+VGdRFzH3DFSB+wqbJ4MvL2z1wKnRfI=
=aubn
-----END PGP SIGNATURE-----

--ykvbjypibdhyxvj7--