From owner-p4-projects@FreeBSD.ORG Mon Aug 11 15:02:06 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 255191065677; Mon, 11 Aug 2008 15:02:06 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD0FE1065674 for ; Mon, 11 Aug 2008 15:02:05 +0000 (UTC) (envelope-from trasz@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CB8838FC13 for ; Mon, 11 Aug 2008 15:02:05 +0000 (UTC) (envelope-from trasz@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7BF25NV026082 for ; Mon, 11 Aug 2008 15:02:05 GMT (envelope-from trasz@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7BF25fu026080 for perforce@freebsd.org; Mon, 11 Aug 2008 15:02:05 GMT (envelope-from trasz@freebsd.org) Date: Mon, 11 Aug 2008 15:02:05 GMT Message-Id: <200808111502.m7BF25fu026080@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to trasz@freebsd.org using -f From: Edward Tomasz Napierala To: Perforce Change Reviews Cc: Subject: PERFORCE change 147155 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2008 15:02:06 -0000 http://perforce.freebsd.org/chv.cgi?CH=147155 Change 147155 by trasz@trasz_traszkan on 2008/08/11 15:01:07 For some reason, mkdir(2) with permissions equal to 01755 results in mode 0755, without sticky bit. Work around this. With this change, ZFS passes regression tests. For now. ;-) Affected files ... .. //depot/projects/soc2008/trasz_nfs4acl/tools/regression/fstest/tests/granular/02.t#3 edit Differences ... ==== //depot/projects/soc2008/trasz_nfs4acl/tools/regression/fstest/tests/granular/02.t#3 (text+ko) ==== @@ -5,7 +5,7 @@ dir=`dirname $0` . ${dir}/../misc.sh -echo "1..52" +echo "1..53" n0=`namegen` n1=`namegen` @@ -90,7 +90,8 @@ expect 0 unlink ${n0} # Check whether modifying the ACL by not-owner preserves the sticky bit. -expect 0 mkdir ${n0} 01755 +expect 0 mkdir ${n0} 0755 +expect 0 chmod ${n0} 01755 expect 0 prependacl ${n0} user:65534:write_acl::allow expect 0 -u 65534 -g 65534 prependacl ${n0} user:65534:write_data::allow expect 01755 stat ${n0} mode