Date: Sun, 6 May 2018 17:04:41 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, Koichiro Iwao <meta@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506150441.52w3lodurubkz2lb@ivaldir.net> In-Reply-To: <CC3C2D9C-F9B7-48DE-A53B-D9193C6CE65E@adamw.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <CC3C2D9C-F9B7-48DE-A53B-D9193C6CE65E@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--kvm6ur37sm772hu4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote: > > On 6 May, 2018, at 04:27, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > >=20 > > On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote: > > > New Revision: 469188 > > > URL: https://svnweb.freebsd.org/changeset/ports/469188 > > >=20 > > > Log: > > > ports-mgmt/pkg_replace: Update to 20180424 > > >=20 > > > - Cleanup code > > > - Speed up and strictly check package's dependencies > > > - While here, pet portlint by using pkg-plist instead of PLIST_FILES > >=20 > > Could you explain what did you achieve by moving three-line PLIST_FILES > > into pkg-plist? How can "pet portlint" be a reason for a change while > > we generally encourage converting <6-line pkg-plist's into PLIST_FILES? > >=20 > > ./danfe > >=20 > > > - > > > -PLIST_FILES=3D sbin/pkg_replace \ > > > - man/man1/pkg_replace.1.gz \ > > > - "@sample %%ETCDIR%%/pkg_replace.conf.sample" > >=20 > > Correct PLIST_FILES should read: > >=20 > > PLIST_FILES=3D sbin/pkg_replace \ > > man/man1/pkg_replace.1.gz \ > > @sample\ etc/pkg_replace/pkg_replace.conf.sample > >=20 > > ./danfe >=20 > Sorry, Alexey, but portlint was right here. @sample and other macros shou= ld > *never* appear in PLIST_FILES. Even if the port installs only a single fi= le, > if it=E2=80=99s a @sample, it goes in pkg-plist. >=20 Same why :) Alexey is wrong imho about the '\' the quotes where fine, but he is right a= bout the replacement of the %%ETCDIR%%. I don't understand why keywords should be forbiddent in PLIST_FILES macros? The framework itself uses macros in PLIST_FILES Best regards, Bapt --kvm6ur37sm772hu4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlrvGYkACgkQY4mL3PG3 PlrPJQ/+Lzk6t7N0sj5cTD4DqwIW6m569dHeIVbV3Ha/3C3r8mcQ45yBLkOZYQbI BV7ZNOROU/Uaf6jRJgjBR3LxAQ19NbWOB2FbzPHp0i2eEKM4RXL+4Rn2pz+xpcQJ QDoEKDWC1SrhbQHgiSoIiBEjK4WKV/cHtZPa8MUMWJk5g8wY8kQMFCX5PzGXBH/w JpYRFSYDjnc4saK7bAyvRq10fscfvxH7W7iY/ixVgyvWPH1ecnOgS5bWhTc2L1GN dkbLEN2mG7KrkZrFCnOJEgykGWb90WggsMP3Nm9jbetQzLK2Pq0m5fHfB/qzuEbz VEoRXa1EFUfD2EXuq6Q6PJcB+g4ZT+lpmY5nsxkXCsLZIGOfCLKRtP92CY1wOsSB yLqa3dsR85ZF52kilBZLK6D4UNAlwdUN9Yrudpgvm5Nz783nYeuUmCuls1daMyis lztL5Na7QMFatTySEjSBFzYhHK1AafQTxzn9U/zZh2IRMQVihIBqVgruHrRANH5s cx6dZzWdQj8utl3hWSMM20AVOzJaBauZey/pXbb6OGm9RqNtyt2D3Wsm7U0pR/bs l5c2CnyLsEfwJKilyNuZzxDYJjEv3yY3JBH3OTYYcwkL0h7YVuJNnOmEbJ6/naMr 8U1wYrzOTv+rLIygRu5usbRena4+JwQRxQQAqIVPytPnWcCI7x4= =fzru -----END PGP SIGNATURE----- --kvm6ur37sm772hu4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180506150441.52w3lodurubkz2lb>