From owner-freebsd-current  Mon Dec 10 20:51:21 2001
Delivered-To: freebsd-current@freebsd.org
Received: from wint.itfs.nsk.su (wint.itfs.nsk.su [212.20.32.43])
	by hub.freebsd.org (Postfix) with ESMTP id 7591D37B405
	for <current@FreeBSD.ORG>; Mon, 10 Dec 2001 20:51:17 -0800 (PST)
Received: (from nnd@localhost)
	by wint.itfs.nsk.su (8.11.6/8.11.4) id fBB4pBX33021;
	Tue, 11 Dec 2001 10:51:11 +0600 (NOVT)
	(envelope-from nnd)
Date: Tue, 11 Dec 2001 10:51:11 +0600 (NOVT)
Message-Id: <200112110451.fBB4pBX33021@wint.itfs.nsk.su>
From: nnd@mail.nsk.ru (Nickolay Dudorov)
To: current@FreeBSD.ORG
Subject: Re: cvs commit: src/sbin/reboot boot_i386.8 src/sys/boot/i386/libi386         bootinfo.c src/sys/i386/i386 autoconf.c src/sys/kern tty_cons.c         src/sys/sys cons.h reboot.h
In-Reply-To: <200112102002.fBAK2Mh21219@freefall.freebsd.org>
User-Agent: tin/1.5.9-20010723 ("Chord of Souls") (UNIX) (FreeBSD/5.0-CURRENT (i386))
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

In article <200112102002.fBAK2Mh21219@freefall.freebsd.org>
Guido van Rooij <guido@FreeBSD.ORG> wrote:
> guido       2001/12/10 12:02:22 PST
> 
>  Modified files:
>    sbin/reboot          boot_i386.8 
>    sys/boot/i386/libi386 bootinfo.c 
>    sys/i386/i386        autoconf.c 
>    sys/kern             tty_cons.c 
>    sys/sys              cons.h reboot.h 
>  Log:
>  Add new boot flag to i386 boot: -p.
>  This flag adds a pausing utility. When ran with -p, during the kernel
>  probing phase, the kernel will pause after each line of output.
>  This pausing can be ended with the '.' key, and is automatically
>  suspended when entering ddb.
>  
>  This flag comes in handy at systems without a serial port that either hang
>  during booting or reser.
>  Reviewed by:    (partly by jlemon)
>  MFC after:      1 week
>  
>  Revision  Changes    Path
>  1.32      +3 -1      src/sbin/reboot/boot_i386.8
>  1.31      +3 -0      src/sys/boot/i386/libi386/bootinfo.c
>  1.160     +1 -1      src/sys/i386/i386/autoconf.c
>  1.97      +24 -0     src/sys/kern/tty_cons.c
>  1.27      +1 -0      src/sys/sys/cons.h
>  1.20      +1 -0      src/sys/sys/reboot.h

	CURRENT kernel is not buildable (in fact "linkable")
after this commit without DDB option.
 There is unguarded by "ifdef DDB" usage of 'db_active'
variable at line 552 of 'src/sys/kern/tty_cons.c'.

	I know that using CURRENT without 'options DDB' is
not recomended, but there is "MFC after: 1 week" in this
commit, so this error must be corrected before this time.

	N.Dudorov

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message