Date: Thu, 7 Mar 2019 13:56:31 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Diane Bruce <db@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r494945 - in head/comms/wsjtx: . files Message-ID: <20190307135631.GA68662@FreeBSD.org> In-Reply-To: <201903071345.x27Dj4Gv030049@repo.freebsd.org> References: <201903071345.x27Dj4Gv030049@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 07, 2019 at 01:45:04PM +0000, Diane Bruce wrote: > New Revision: 494945 > URL: https://svnweb.freebsd.org/changeset/ports/494945 > > Log: > - update to 2.0.1 > - builds on i386 now > - remove MAKE_JOBS_UNSAFE When removing MAKE_JOBS_UNSAFE, it is expected to explain what was wrong before and why it is believed to be fixed now, otherwise the error might have simply not manifested itself. > this updated port. The cmake build provided does not have an > install/strip target which forces use of do-install. > ... > +do-install: > + (cd ${CONFIGURE_WRKSRC};${MAKE} -f Makefile DESTDIR=${STAGEDIR} install) This do-install target is very bogus (CONFIGURE_WRKSRC? ${MAKE}? whitespace bugs), but more importantly, why not patch CMakeLists.txt to provide a nice installation routine instead of this ugliness? > Added: > head/comms/wsjtx/files/hamlib.patch (contents, props changed) > head/comms/wsjtx/files/wsjtx.patch (contents, props changed) > ... > +post-patch: > + ${CP} ${FILESDIR}/wsjtx.patch ${WRKSRC} > + ${CP} ${FILESDIR}/hamlib.patch ${WRKSRC} Can't these be converted to normal patch-* files? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190307135631.GA68662>