From owner-svn-ports-head@FreeBSD.ORG Sat Oct 12 00:39:51 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 689FC6EE for ; Sat, 12 Oct 2013 00:39:51 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 471D12E0D for ; Sat, 12 Oct 2013 00:39:51 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9C0dprx047179 for ; Sat, 12 Oct 2013 00:39:51 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9C0dpKF047174 for svn-ports-head@freebsd.org; Sat, 12 Oct 2013 00:39:51 GMT (envelope-from bdrewery) Received: (qmail 15846 invoked from network); 11 Oct 2013 19:39:49 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 11 Oct 2013 19:39:49 -0500 Message-ID: <52589A4E.3070506@FreeBSD.org> Date: Fri, 11 Oct 2013 19:39:42 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Gerald Pfeifer Subject: Re: svn commit: r327601 - head/Mk References: <201309190805.r8J855cW009011@svn.freebsd.org> <20130921023225.GA19307@FreeBSD.org> <20130921104936.GQ73535@ithaqua.etoilebsd.net> <523D7B20.6020908@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.5.2 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AsaS7PxAHqliHa6ErSb6jfMIw2aFI50Qo" Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , Baptiste Daroussin , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Oct 2013 00:39:51 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AsaS7PxAHqliHa6ErSb6jfMIw2aFI50Qo Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 10/11/2013 7:37 PM, Gerald Pfeifer wrote: > On Sat, 21 Sep 2013, Bryan Drewery wrote: >> We also plan to add more commit hooks for things that portlint has >> checked for. Not everyone runs portlint, and portlint is essentially >> unmaintained. It is currently severely lagging behind in feature-set >> checking. By moving to ports, the feature-set checking is always >> matching the tree. >=20 > This is a bit confusing, and I think there are things portlint checks > for that the ports infrastructure cannot? >=20 > For example, a recent sweep to replace LAST_LINK by PKGNAMESUFFIX > triggered new portlint warnings for me since PKGNAMESUFFIX was added > at the wrong place. This static analysis could be done by a hook. >=20 > I thought we all are supposed to run portlint before commits? Yes, but it's severely outdated and no one has stepped up to fix that or take proper maintainership of it. It currently gives incorrect advice on multiple common cases. >=20 > Gerald >=20 --=20 Regards, Bryan Drewery --AsaS7PxAHqliHa6ErSb6jfMIw2aFI50Qo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSWJpOAAoJEG54KsA8mwz5jCwP/3ua4rSh1Xb8sn2R1GEdSAVv yRoDBMsmAocODVHk/11stUwUM0a6c6itmdmE3DMUsmoDd0OxbYoj8lsrDB8cd5w+ 6OFw3H7jQQsDdTaDnAhXo0Im9lX6L7NIAXR+qXupUc1DBYBugz2Z42fye+QaF5RT eUJB+Wnq8Chp8Z6FGnK/tvBrIRir7Itqr+ny4y2fDOnE1LG6UP7BwjmSZ9AeOqIg vwNzTj21pyfm2qltPAboTwEJL3f+Psr1qgrR9lG2xAwSwHXKmRyradeI14814ydg U/nZcpL134JLVEurKK+8HqUjHJYXFuS+mLE8Jvffdb24jdTcxVCTvAY62D6AIxfW xIaHF3zYpsTu7KfUftiJLoCirktRn9PV4Nf+B5ePFdpUixhMzjDb9iTGkBjie0LF nRPJvjSQjLE8zDMvxTD5zrX7nNySQi2Tzyw/34FiEEvighMWR59TtDygmNOeZcqr SwGKpaHdf08WXJ0eM3pTUtjCLPfyg4kYyKWXvLNwbzAJHYAjjPbZrADL9liEgSKM WDQI3lKQ4nj2RLbxJCrlQB5ImbArojidnQ2DJwra+QYmkQOJgU+9xbHPitA8XXtF 4jK0Tv7LHY2KbM2nVa4QYCczWBDrkRU3AiVt7ThP3dcYTaxKSd/du493KGtKia1V ixD+M5An4Mur4NvJBImk =CRlX -----END PGP SIGNATURE----- --AsaS7PxAHqliHa6ErSb6jfMIw2aFI50Qo--