From nobody Tue Jun 20 01:18:08 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QlTKW0xk1z4f8Gv for ; Tue, 20 Jun 2023 01:18:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QlTKV05Zqz3qH9 for ; Tue, 20 Jun 2023 01:18:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-988c495f35fso178355366b.1 for ; Mon, 19 Jun 2023 18:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1687223900; x=1689815900; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cf5LWpuN/1SK0jPjJ4gh/DgmM5Wy3i93mvPxsQZ0uvk=; b=PT3AwhU3z2zJT/18OlJPjadNjPip9D8wGSdeSRpirFZlNPcXv6rn6Y107PgOR2qOU3 dTmZJzNwHiUdbqlypTFQ2Q7Q+fX7EEdNKitm8gSjEhmNNQk1/7YUNFW31puxu8ZYc5Uz GozaB6G4hMU/7AEPxuxDdm26PZso5O68RiHg8Fv7xMs6JhX/tyrFiMeYUzJ1NxFPS4j2 96ZFzgSVnw6rMoWjg9F+NuaPPuhi5dTnBB76z/y49cOwpEBEuk1kxx0lPNjwdjhu/q6w 5nwml3dq6W9suNZqMgJkYU6W2naGMB4wxXRsS59E1dJK6JqXbltGoVCplLnh+ElMD3un yUMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687223900; x=1689815900; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cf5LWpuN/1SK0jPjJ4gh/DgmM5Wy3i93mvPxsQZ0uvk=; b=atN3eRzFNgyymqkfvOm+WfVCdtMX/tYQnNtXVvtCAxcnoNc354HyXK6DRLI0UmdR/T UXQ2Qs35U+ZdXNnfMq6wPxz4hE4TvfKHfNh37seGrrvGqTFii3s5F0OFDqoYorLkya3l wtnYQrlyi5Rv2ai8hFpHHKM/jyNWlz0Hhq2kFCa8cWMWxa8oHk42Rs0smyk0f2zu7/tL Pbb0whYknwvha3fT/wZ4gKV8Iv1iRehT6DcvR9ZI9UU7AC/vE+QCCkm8vicPOeG8rMzk FlOWcqs7UHIZwvKyuZ7JOHvl3QWgzn7ErenYramdNuaZDyeONZvfqP1+yxLNXBxt7ytE H6gw== X-Gm-Message-State: AC+VfDzSzhCA2lJXJjevcnXIg6HdewBcrUmHhZNcFG/Ukjq8M4tark6k qxrzwI0SK5xZNmh+veIbpgiV4h9etM4g79KDdHfe6ZMmvcUC8eNC X-Google-Smtp-Source: ACHHUZ70jhe1D7kFNSmQAr0LKbhNn4h0P/G16+oqQEBKi60yhNcmfJvVugj2Nw0Sfq/pFEvMRJ8KoKsS52C3zhPQC6c= X-Received: by 2002:a17:907:3605:b0:989:450:e56a with SMTP id bk5-20020a170907360500b009890450e56amr1185263ejc.76.1687223899682; Mon, 19 Jun 2023 18:18:19 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202306200023.35K0NSlA057479@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Mon, 19 Jun 2023 19:18:08 -0600 Message-ID: Subject: Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list To: Ed Maste Cc: Colin Percival , src-committers , "" , "" Content-Type: multipart/alternative; boundary="00000000000032883905fe856d7c" X-Rspamd-Queue-Id: 4QlTKV05Zqz3qH9 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000032883905fe856d7c Content-Type: text/plain; charset="UTF-8" On Mon, Jun 19, 2023, 7:04 PM Ed Maste wrote: > On Mon, 19 Jun 2023 at 20:23, Colin Percival wrote: > > > > The branch main has been updated by cperciva: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=b908f6c45e0202deb86fc9bde1b07212924c05fc > > > > commit b908f6c45e0202deb86fc9bde1b07212924c05fc > > Author: Colin Percival > > AuthorDate: 2023-06-17 20:08:37 +0000 > > Commit: Colin Percival > > CommitDate: 2023-06-20 00:23:09 +0000 > > > > bsd.mkopt.mk: Add REQUIRED_OPTIONS list > > > > Options on this list will be forced to 'yes'. This is intended for > use > > as a transitional measure when an option is ceasing to be optional, > > before all of the associated make logic is removed. > > Should we emit a warning when an option is disabled in src.conf but > specified in REQUIRED_OPTIONS? > > e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer supported > I asked for this in the review... I didn't approve the review because I was waiting for an answer to the request. Warner > --00000000000032883905fe856d7c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jun 19, 2023, 7:04 PM Ed Maste <emaste@freebsd.org> wrote:
On Mon, 19 Jun 2023 at 20:23, Colin Percival <= cperciva@freebsd.org> wrote:
>
> The branch main has been updated by cperciva:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3Db908f6c45e0202deb86fc9bde1b072= 12924c05fc
>
> commit b908f6c45e0202deb86fc9bde1b07212924c05fc
> Author:=C2=A0 =C2=A0 =C2=A0Colin Percival <cperciva@FreeBSD.org>=
> AuthorDate: 2023-06-17 20:08:37 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Colin Percival <cperciva@FreeBSD.org>=
> CommitDate: 2023-06-20 00:23:09 +0000
>
>=C2=A0 =C2=A0 =C2=A0bsd.mkopt.mk: Add REQUIRED_OPTIONS list >
>=C2=A0 =C2=A0 =C2=A0Options on this list will be forced to 'yes'= ;.=C2=A0 This is intended for use
>=C2=A0 =C2=A0 =C2=A0as a transitional measure when an option is ceasing= to be optional,
>=C2=A0 =C2=A0 =C2=A0before all of the associated make logic is removed.=

Should we emit a warning when an option is disabled in src.conf but
specified in REQUIRED_OPTIONS?

e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer supported

I a= sked for this in the review... I didn't approve the review because I wa= s waiting for an answer to the request.=C2=A0

Warner=C2=A0
--00000000000032883905fe856d7c--