From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:52:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EB2016A4CE; Wed, 3 Nov 2004 16:52:53 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DBC243D48; Wed, 3 Nov 2004 16:52:52 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA3Gsegf020515; Wed, 3 Nov 2004 09:54:41 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <41890D26.5050101@freebsd.org> Date: Wed, 03 Nov 2004 09:53:58 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103.094841.89130476.imp@bsdimp.com> In-Reply-To: <20041103.094841.89130476.imp@bsdimp.com> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: phk@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:52:53 -0000 M. Warner Losh wrote: > In message: <418905E5.1050605@freebsd.org> > Scott Long writes: > : Poul-Henning Kamp wrote: > : > phk 2004-11-03 14:11:18 UTC > : > > : > FreeBSD src repository > : > > : > Modified files: > : > sys/dev/em if_em.c > : > Log: > : > Put the "Link is up/down" printfs behind bootverbose. gigE is not so uncommon > : > that we need to tell people about every cable in the network anymore. It can > : > be enabled for debugging purposes with "boot -v". > : > > : > Revision Changes Path > : > 1.51 +8 -6 src/sys/dev/em/if_em.c > : > : I think that in general we can start eyeing a lot of similar verbosity > : in all of our drivers, both at boot and at runtime. For example most > : nic drivers print out their MAC and all of their possible negotiation > : rates on attach. This same info can be obtained from ifconfig. Why > : clutter the boot with it? > > Well, you can't get all the info you need from ifconfig. If you want > to know WHICH nic is in WHAT slot, it is a lot easier to get that from > the one liner printed on boot (especially when trying to troubleshoot > things) than to get it from ifconfig + dmesg. I think that's useful > to continue to have there. > > I do agree that the rate thing of the wireless drivers is excessive, > as is many of the rate things. > > fwohci likely can use some trimming as well, even in the non-verbose > mode. > > The CAM messages are the only messages in FreeBSD more verbose than > VMS :-) > > Warner I've looked at the CAM messages, yes. I'm not calling for immediate action, just saying that it's something to keep an eye on and think about. Scott