From owner-svn-ports-head@freebsd.org Thu Jan 2 03:49:39 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0FD211EA835 for ; Thu, 2 Jan 2020 03:49:39 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47pDYt6mCGz3H0N for ; Thu, 2 Jan 2020 03:49:38 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id B67A550D1 for ; Thu, 2 Jan 2020 03:49:38 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f51.google.com with SMTP id l8so38089539edw.1 for ; Wed, 01 Jan 2020 19:49:38 -0800 (PST) X-Gm-Message-State: APjAAAXe89Mi4HxMz+r7dXJlu9FOvGB4mDBOvkboYxltIG9V8YGwE2Yv wdxeeAD7Kn00WKBycL8m5GwqvmHP3yfY2tkiBDfjvg== X-Google-Smtp-Source: APXvYqy+RdbwutvUDxOWvcQ5MAoZ9b1FDDyCf/fuqnNgzi8tSuS1yHvXLEtoh7/euhuhPwozKzVnV3DUpVvSzwZemL4= X-Received: by 2002:a17:906:8554:: with SMTP id h20mr86244703ejy.203.1577936977391; Wed, 01 Jan 2020 19:49:37 -0800 (PST) MIME-Version: 1.0 References: <202001011631.001GVQTM023723@repo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Thu, 2 Jan 2020 11:49:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r521738 - head/devel/rubygem-rspec To: Adam Weinberger Cc: ports-committers , svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 03:49:39 -0000 On Thu, Jan 2, 2020, 01:05 Adam Weinberger wrote: > On Wed, Jan 1, 2020 at 9:31 AM Sunpoet Po-Chuan Hsieh > wrote: > > > > Author: sunpoet > > Date: Wed Jan 1 16:31:26 2020 > > New Revision: 521738 > > URL: https://svnweb.freebsd.org/changeset/ports/521738 > > > > Log: > > Update version requirement of RUN_DEPENDS > > > > - Take maintainership > > I have to ask: Why are you taking maintainership of all these > community-maintained modules? You're already the main person on ruby@, > so grabbing maintainership when you update a port simply deprives > others of the ability to contribute to them. > > Like, for example, that this rspec commit missed the fact that 3 of > the updates were already stale. I would have done the bumps myself, > but cannot do so now. (Don't get me wrong; I know you always catch > them and the updates are coming in the next few days.) But I urge you > to slow down on maintainership-grabbing from community-maintained > modules, unless there's some reason that nobody else should be > altering them. > > # Adam > Hi Adam, The main reason is that the latest rspec* update from 3.8.* to 3.9.0 missed rspec-rails which was 3.8.2 and requires rspec* ~> 3.8.0. that's why i want to take them and update the RUN_DEPENDS version range. > > > > Modified: > > head/devel/rubygem-rspec/Makefile > > > > Modified: head/devel/rubygem-rspec/Makefile > > > ============================================================================== > > --- head/devel/rubygem-rspec/Makefile Wed Jan 1 16:31:20 2020 > (r521737) > > +++ head/devel/rubygem-rspec/Makefile Wed Jan 1 16:31:26 2020 > (r521738) > > @@ -6,18 +6,19 @@ PORTVERSION= 3.9.0 > > CATEGORIES= devel rubygems > > MASTER_SITES= RG > > > > -MAINTAINER= ruby@FreeBSD.org > > +MAINTAINER= sunpoet@FreeBSD.org > > COMMENT= Behaviour Driven Development in Ruby > > > > LICENSE= MIT > > LICENSE_FILE= ${WRKSRC}/LICENSE.md > > > > -RUN_DEPENDS= > rubygem-rspec-core>=${PORTVERSION:R}.0:devel/rubygem-rspec-core \ > > - > rubygem-rspec-expectations>=${PORTVERSION:R}.0:devel/rubygem-rspec-expectations > \ > > - > rubygem-rspec-mocks>=${PORTVERSION:R}.0:devel/rubygem-rspec-mocks > > +RUN_DEPENDS= > rubygem-rspec-core>=${PORTVERSION:R}.0<3.10:devel/rubygem-rspec-core \ > > + > rubygem-rspec-expectations>=${PORTVERSION:R}.0<3.10:devel/rubygem-rspec-expectations > \ > > + > rubygem-rspec-mocks>=${PORTVERSION:R}.0<3.10:devel/rubygem-rspec-mocks > > > > -NO_ARCH= yes > > -USE_RUBY= yes > > USES= gem > > +USE_RUBY= yes > > + > > +NO_ARCH= yes > > > > .include > > > > -- > Adam Weinberger > adamw@adamw.org > https://www.adamw.org >