From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Mar 14 12:10:12 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BBFC1065672 for ; Mon, 14 Mar 2011 12:10:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 596F48FC0A for ; Mon, 14 Mar 2011 12:10:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p2ECACUR061671 for ; Mon, 14 Mar 2011 12:10:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p2ECACfV061670; Mon, 14 Mar 2011 12:10:12 GMT (envelope-from gnats) Resent-Date: Mon, 14 Mar 2011 12:10:12 GMT Resent-Message-Id: <201103141210.p2ECACfV061670@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gerald Pfeifer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 611501065676 for ; Mon, 14 Mar 2011 12:05:27 +0000 (UTC) (envelope-from gerald@FreeBSD.org) Received: from ref8-amd64.freebsd.org (ref8-amd64.freebsd.org [IPv6:2001:4f8:fff6::5f]) by mx1.freebsd.org (Postfix) with ESMTP id 51B7E8FC16; Mon, 14 Mar 2011 12:05:27 +0000 (UTC) Received: from ref8-amd64.freebsd.org (localhost [127.0.0.1]) by ref8-amd64.freebsd.org (8.14.4/8.14.4) with ESMTP id p2EC5R1u066688; Mon, 14 Mar 2011 12:05:27 GMT (envelope-from gerald@ref8-amd64.freebsd.org) Received: (from gerald@localhost) by ref8-amd64.freebsd.org (8.14.4/8.14.4/Submit) id p2EC5RBA066687; Mon, 14 Mar 2011 12:05:27 GMT (envelope-from gerald) Message-Id: <201103141205.p2EC5RBA066687@ref8-amd64.freebsd.org> Date: Mon, 14 Mar 2011 12:05:27 GMT From: Gerald Pfeifer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/155550: portlint shall warn about CPPFLAGS being passed to CONFIGURE_ENV and MAKE_ENV X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2011 12:10:12 -0000 >Number: 155550 >Category: ports >Synopsis: portlint shall warn about CPPFLAGS being passed to CONFIGURE_ENV and MAKE_ENV >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Mar 14 12:10:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: >Organization: >Environment: >Description: Recently a change of mine to pass CPPFLAGS to CONFIGURE_ENV and MAKE_ENV has been applied to Mk/bsd.port.mk. In consequence, individual ports no long should pass this to either explicitly, that is, it would be great could portlint warn about the like of CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}" and MAKE_ENV= CPPFLAGS="${CPPFLAGS}" In fact, not just the forms about, but any setting of CPPFLAGS in these two, also along the lines of CONFIGURE_ENV= CPPFLAGS="${SOMETHING_ELSE}" or MAKE_ENV= CPPFLAGS="-Dfoo -D bar" should be warned about since, really, CPPFLAGS should be set in the port Makefile and the rest should "just happen". A regular expression could like something like ^(CONFIGURE_ENV|MAKE_ENV)(=|?=|+=).*CPPFLAGS >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: