Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 01 Jun 2024 20:46:48 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   [Bug 279280] graphics/gegl: sort out Makefile and pet portclippy
Message-ID:  <bug-279280-6497-c7ebWp3b0Q@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-279280-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-279280-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279280

--- Comment #4 from Vladimir Druzenko <vvd@FreeBSD.org> ---
(In reply to Daniel Engberg from comment #3)
> Drop the omp hack?
Replaced:
.if !exists(/usr/include/omp.h)
A
.else
B
.endif
with:
.if exists(/usr/include/omp.h)
B
.else
A
.endif

> Please move GEGL_VER=3D and PLIST_SUB+ (remove + too?) above MESON_ARGS f=
or consistency with the tree
portclippy said MESON_ARGS must be before PLIST_SUB.

> Place *_IMPLIES=3D below MESON_ARGS
portclippy said *_IMPLIES=3D must be before even *_BUILD_DEPENDS=3D

> tools/gobj2dot.py isn't called during build (needs shebangfix)?
Nothing changed around this.
/usr/ports/graphics/gegl/work/gegl-0.4.48/tools/gobj2dot.py: "#!/usr/bin/env
python3"
If add to shebangfix, than changed to "#!/usr/local/bin/python".
Testing with and without and then compare build logs.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-279280-6497-c7ebWp3b0Q>