From owner-dev-commits-src-all@freebsd.org Sun Jan 10 11:12:48 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CFC1C4C835C; Sun, 10 Jan 2021 11:12:48 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay110.isp.belgacom.be (mailrelay110.isp.belgacom.be [195.238.20.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign RSA OV SSL CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DDDhb3Hzsz4Tky; Sun, 10 Jan 2021 11:12:47 +0000 (UTC) (envelope-from tijl@coosemans.org) IronPort-SDR: kJLz3GeVuwWP4EvYNrESlM44LTw4+k+mM+qUaIcOBCXCyXjr+BlK3rVT0AOn3lda50HvpmJSfM ypS7YyOm+k58BnUg28zVWuQd5CrPT/vfrUYTJENOCyi7150qZmeuJkrKW0apCUzzcu8KivSC76 T8kkblWbJkj3VVofwbFenS+qNBeyy6SmmmHSZUbP/ynPFd3BkFL8SfqlC7zaP4DKO7A0gBBHpq aXbVZlLbTAzQu5P7Ff33cUcy8NCyaRem9kzABzobUUmZ0Qmsqaj3ZaB+EqUJJTH96NoEghjNpA VsY= X-Belgacom-Dynamic: yes IronPort-PHdr: =?us-ascii?q?9a23=3ARmi2Yxd64K0gPhVIlaYh0qGxlGMj4u6mDksu8p?= =?us-ascii?q?Mizoh2WeGdxc27YhGN2/xhgRfzUJnB7Loc0qyK6v+mAzBRqszd+Fk5M7V0Hy?= =?us-ascii?q?cfjssXmwFySOWkMmbcaMDQUiohAc5ZX0Vk9XzoeWJcGcL5ekGA6ibqtW1aFR?= =?us-ascii?q?rwLxd6KfroEYDOkcu3y/qy+5rOaAlUmTaxe7x/IAi0oAnLqMUbjo9vJqkvxh?= =?us-ascii?q?bGv3BFZ/lYyWR0KFyJgh3y/N2w/Jlt8yRRv/Iu6ctNWrjkcqo7ULJVEi0oP3?= =?us-ascii?q?g668P3uxbDSxCP5mYHXWUNjhVIGQnF4wrkUZr3ryD3q/By2CiePc3xULA0RT?= =?us-ascii?q?Gv5LplRRP0lCsKMSMy/XrJgcJskq1UvBOhpwR+w4HKZoGVKOF+db7Zcd8DWG?= =?us-ascii?q?ZNQtpdWylHD4ihbYUAEvABMP5WoYf9uVUAsBiwCguiBOzg1jBGiWT73bE43u?= =?us-ascii?q?k7DQ3KwBAsE8wIvX/JrNv1LqASUeWtwafWyDfDa+5d1Cn66IjPaRAuv/SMUq?= =?us-ascii?q?h2ccrK1EIiEB/FjlSSqYzhJD6ayuMNs2+A7+V+UOKgkWgnqxprrjio3McshZ?= =?us-ascii?q?DEi4QIwV/L6St32pw6JcGkSEFle96kFoNduzyGOodoQs4uXWFmtig0xLAJpJ?= =?us-ascii?q?K2fzYGxYgnyhPfdfCLboyF7xP+WeuPITp0mXxrdK+iixi970St1vPxW9e03V?= =?us-ascii?q?tMsyFLnN7MtnUX2BzS7MiKUvV9/l2/1jmRzA/T8fxLLVozlarBJJ4t2rkwlo?= =?us-ascii?q?IPsUTYBCP2nUb2gamLfUsn4uil8+fqbqj8qpOCOIJ4lBvyPrksl8ChG+g1PQ?= =?us-ascii?q?4DVHWB9+umzr3s50j5Ta1Pjv0xj6bWrojXJd8epq6lGw9V1Zsj6wqnAzemzt?= =?us-ascii?q?sYmX4HIUpGeB2di4jpOlTOL+7iDfe4mVisjDZrx/LCPrH7HprNKX/DkKz/cr?= =?us-ascii?q?Z48UFczhEzwcpY55JOBbENOPPzWknvu9zEFhI0MBG4z/z5BNhyyI8SQ3+DD6?= =?us-ascii?q?2HPK/IvlKE/ucvLPONZI8Rtjb9Mf8l5/v2gH8lmF8df62p0IALZ3C/GfRmOF?= =?us-ascii?q?uWYX/2jdcHCmcGpA0+TPbliFGaSz5ce26yX74g5jE8EI+pEJnMRp60jLOd2y?= =?us-ascii?q?e7G5hWZmFaClCXCHvobJ+EVOsVZCKXOMBhkzoEWKOvS487yx6hqhT1y6F6Ie?= =?us-ascii?q?bO/S0Yr53j3sBv5+LPjREy6SB0D8OF3m6QUW50gHoESCMx3KB6pEx9y0uD0b?= =?us-ascii?q?Nhj/xDD9xc++pFXR0+NZ7Y1OF6BcryVRzfcdiSU1apX8+qATYrTtI+29UOeV?= =?us-ascii?q?pyG82+jhDf2CqnG6QVl6aXC5At7q3c2H3xJ8N8y3bayKkukUMmQtBUOG2onK?= =?us-ascii?q?5w6RbcCJXSk0qEjaqqcr4c3CHV/meZ0WWOpF1YUBJ3UajdR38ffErWosj55k?= =?us-ascii?q?zYVb+hFK8nMgxHycOZJKtKcMPmgktdS/f4JdvSeWWxm32/BUXA+rTZRY7nay?= =?us-ascii?q?0n3S7dAVIIiAcVtSKPLwk1Bi67r3nZChRAD1/iSXjAt+5kpyXoYFUzylS2iE?= =?us-ascii?q?kp/L2y4RMQjPqHA6cP37AAkCwmrC55GV+7xJTREdXW9FkpR7lVfd5ouAQP7m?= =?us-ascii?q?nerQEoe8X4d60=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2C2AQCQ4Ppf/wSs8lFiGgEBAQEBAQE?= =?us-ascii?q?BAQEDAQEBARIBAQEBAgIBAQEBQAeBSAIBgx5XAWCNQ4YhghYDOIg8giiRIAs?= =?us-ascii?q?BAQEBAQEBAQEwCAQBAYRKAoFxJjkFDQIDAQEBAwIFAQEGAQEBAQEBBQQBhhg?= =?us-ascii?q?5DEMBAQEBAgEGBIFkKQGDEgEFJxM/EAsOCi5XBhODJ4MKC60FgQEzhD8BgRi?= =?us-ascii?q?DZYEHgTgBjTBBPoFCgRGDGT6CRhcEF4c+BIJEeD4Be1ItFwGcQ5wqgwGJK5I?= =?us-ascii?q?lMYMpgTCIf5UILYVxmQqSCoY3gXlNMAiDJAlHGQ2WMXWFRUADMAIBAQcsAgY?= =?us-ascii?q?KAQEDCYMyToMOhjsBAQ?= X-IPAS-Result: =?us-ascii?q?A2C2AQCQ4Ppf/wSs8lFiGgEBAQEBAQEBAQEDAQEBARIBA?= =?us-ascii?q?QEBAgIBAQEBQAeBSAIBgx5XAWCNQ4YhghYDOIg8giiRIAsBAQEBAQEBAQEwC?= =?us-ascii?q?AQBAYRKAoFxJjkFDQIDAQEBAwIFAQEGAQEBAQEBBQQBhhg5DEMBAQEBAgEGB?= =?us-ascii?q?IFkKQGDEgEFJxM/EAsOCi5XBhODJ4MKC60FgQEzhD8BgRiDZYEHgTgBjTBBP?= =?us-ascii?q?oFCgRGDGT6CRhcEF4c+BIJEeD4Be1ItFwGcQ5wqgwGJK5IlMYMpgTCIf5UIL?= =?us-ascii?q?YVxmQqSCoY3gXlNMAiDJAlHGQ2WMXWFRUADMAIBAQcsAgYKAQEDCYMyToMOh?= =?us-ascii?q?jsBAQ?= Received: from 4.172-242-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.242.172.4]) by relay.skynet.be with ESMTP; 10 Jan 2021 12:12:44 +0100 Received: from localhost (localhost [127.0.0.1]) by kalimero.tijl.coosemans.org (8.16.1/8.16.1) with ESMTP id 10ABCgJX001851; Sun, 10 Jan 2021 12:12:43 +0100 (CET) (envelope-from tijl@coosemans.org) Date: Sun, 10 Jan 2021 12:12:42 +0100 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Alex Richardson Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7fa2f2a62f04 - main - Rename NO_WERROR -> MK_WERROR=no Message-ID: <20210110121242.1d9809ff@coosemans.org> In-Reply-To: <202101071105.107B5tUX011254@gitrepo.freebsd.org> References: <202101071105.107B5tUX011254@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DDDhb3Hzsz4Tky X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of tijl@coosemans.org has no SPF policy when checking 195.238.20.137) smtp.mailfrom=tijl@coosemans.org X-Spamd-Result: default: False [-2.20 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[195.238.20.137:from]; FREEFALL_USER(0.00)[tijl]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[coosemans.org]; ARC_NA(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[195.238.20.137:from]; SPAMHAUS_ZRD(0.00)[195.238.20.137:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5432, ipnet:195.238.0.0/19, country:BE]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-main,dev-commits-src-all]; RCVD_IN_DNSWL_LOW(-0.10)[195.238.20.137:from] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jan 2021 11:12:48 -0000 On Thu, 7 Jan 2021 11:05:55 GMT Alex Richardson wrote: > The branch main has been updated by arichardson: > > URL: https://cgit.FreeBSD.org/src/commit/?id=7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f > > commit 7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f > Author: Alex Richardson > AuthorDate: 2021-01-06 17:55:06 +0000 > Commit: Alex Richardson > CommitDate: 2021-01-07 09:31:03 +0000 > > Rename NO_WERROR -> MK_WERROR=no > > As suggested in D27598. This also supports MK_WERROR.clang=no and > MK_WERROR.gcc=no to support the existing NO_WERROR. uses. > > Reviewed By: brooks > Differential Revision: https://reviews.freebsd.org/D27601 > --- > diff --git a/share/mk/bsd.opts.mk b/share/mk/bsd.opts.mk > index d0e7f1cb00ba..88c73cc6bfe4 100644 > --- a/share/mk/bsd.opts.mk > +++ b/share/mk/bsd.opts.mk > @@ -65,7 +65,8 @@ __DEFAULT_YES_OPTIONS = \ > SSP \ > TESTS \ > TOOLCHAIN \ > - WARNS > + WARNS \ > + WERROR > > __DEFAULT_NO_OPTIONS = \ > BIND_NOW \ > @@ -103,7 +104,8 @@ __DEFAULT_DEPENDENT_OPTIONS = \ > INSTALLLIB \ > MAN \ > PROFILE \ > - WARNS > + WARNS \ > + WERROR > .if defined(NO_${var}) > .error "NO_${var} is defined, but deprecated. Please use MK_${var}=no instead." > MK_${var}:=no NO_WERROR is also used by some ports [1] (which have to build against multiple version of FreeBSD) and this turns it into an error. Can you remove this change or turn it into a warning maybe? Changes to share/mk should always go through a ports exp-run IMHO. [1] http://beefy17.nyi.freebsd.org/data/main-i386-default/p560826_se83fdf8bb3/logs/linux_libusb-13.0r358841_4.log