From nobody Wed Apr 27 22:01:12 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B30071ABFAB7; Wed, 27 Apr 2022 22:01:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KpXkw4gqZz3t8f; Wed, 27 Apr 2022 22:01:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651096872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xpe9Fpvm+OVxEQVq8TVT4awMS2eMtK3rIX7tiEz5UVA=; b=AKeENTXFjhm1Nrd8DCMszz8WNt9BOaTOxl5tAtxyVigXhGgFe+XepH7gmKiV0JLdP8hqSB vg/4vPYGazQb0QnF6/Gn9xzboUT5eaHDz2poZ16KHdmoOA3iYcCvIXtcdgJ3qk4Rr/L+GO U+bERYY9QR5NCrG+E2kEPjGN5FA8luO7yAC60VBaM/g3Qhdp7nK52XqqAl75oWOGlexEvT OApZrhOawiUuwQiRQGXWD1XtG8cMcq9uNN+JZn+Mk/E1gA6jvJyoe3sKexEFEFwZtbZpU7 axxRW0wveq9PGQX3YgkRh0iZma6Dna/xNOphNz171fmqiZ06fe/IA5/GYk6deA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 807FC43FC; Wed, 27 Apr 2022 22:01:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23RM1CHx060841; Wed, 27 Apr 2022 22:01:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23RM1CvA060840; Wed, 27 Apr 2022 22:01:12 GMT (envelope-from git) Date: Wed, 27 Apr 2022 22:01:12 GMT Message-Id: <202204272201.23RM1CvA060840@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Justin Hibbits Subject: git: de6353ad8fdf - main - gpiopower: Fix call to ofw_gpiobus_parse_gpios List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: de6353ad8fdf3783d19012fec7c1d69926a3f772 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651096872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xpe9Fpvm+OVxEQVq8TVT4awMS2eMtK3rIX7tiEz5UVA=; b=W9oCnJghyRGllIlwjtYK2ooUaAZpInkj34gdPUQKZ7/8iWesR7BqtkefcB2Lkkrzc8fMma 3fKmT1uFuwbP8YFsCODtN4STGR0SyesPC/GZdrT2M+L4O0Pav2qP1OSdoauPY09SWCMdgS +A6Uk6C1m5TsJ7Iv+Nsj3TjDkORuEWKeCbcgKP1ndYEAZKCVIlWJKXl+L20rrig83B03I7 eEiEPQsp4hzILx6Ie9QmyosXLtHF6s9Jtm1Wr/G8kTqE3w0UrtmceoNferI80DzUwmwoxU orkoZDldNXiQJDJdSLCXMrCHcWj+csObWfB/jIUT5+Q2WKMnhzyXMWH2LpsYVQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651096872; a=rsa-sha256; cv=none; b=PmWwMtYBneZ3uRs3Muo+6GHHjXz2K/W+SzBViIM64ODUHNUR9bMGGFDL96ziJNzau8VmDc RtGbERx/EoXlHBwbKsISk1UgAja77usPBonnE2QWCL9YHJ0iQukokSOtiZnm64nE4KUBK4 W66DQhNVD6nBtqKOi1jAFjRtKyEhcwYfTiqMEoq47r/mxLLX9ejL/vvwGhuF/jyN3kwyJT 1NpJk+yHvepcIIZ8q4SC26jMgcf0KrI2eoJKP6P6CVHqGheYbO1E2AuueJTu0mYqoZMFVx lca2/FDDnofStE7H36wJFyyS36x9KAM+wPWUWyebEuMslI/LEjoaYz9f3KApzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=de6353ad8fdf3783d19012fec7c1d69926a3f772 commit de6353ad8fdf3783d19012fec7c1d69926a3f772 Author: Justin Hibbits AuthorDate: 2022-04-27 21:55:28 +0000 Commit: Justin Hibbits CommitDate: 2022-04-27 22:00:32 +0000 gpiopower: Fix call to ofw_gpiobus_parse_gpios Failure is denoted by -1, not non-zero. A positive integer denotes the number of pins mapped and configured. --- sys/dev/gpio/gpiopower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/gpio/gpiopower.c b/sys/dev/gpio/gpiopower.c index 3dcd489ed2fb..3a87ba6597ce 100644 --- a/sys/dev/gpio/gpiopower.c +++ b/sys/dev/gpio/gpiopower.c @@ -74,7 +74,7 @@ gpiopower_attach(device_t dev) if ((node = ofw_bus_get_node(dev)) == -1) return (ENXIO); - if (ofw_gpiobus_parse_gpios(dev, "gpios", &sc->sc_pin) != 0) { + if (ofw_gpiobus_parse_gpios(dev, "gpios", &sc->sc_pin) <= 0) { device_printf(dev, "failed to map GPIO pin\n"); return (ENXIO); }