From owner-svn-ports-head@freebsd.org  Fri Jun 21 14:54:05 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF17215B357B;
 Fri, 21 Jun 2019 14:54:05 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 810216C59A;
 Fri, 21 Jun 2019 14:54:05 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 5653516FC1; Fri, 21 Jun 2019 14:54:05 +0000 (UTC)
Date: Fri, 21 Jun 2019 14:54:05 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Christoph Moench-Tegeder <cmt@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r504800 - in head/cad: . kicad-doc
Message-ID: <20190621145405.GA390@FreeBSD.org>
References: <201906211352.x5LDq1E6071357@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201906211352.x5LDq1E6071357@repo.freebsd.org>
User-Agent: Mutt/1.11.4 (2019-03-13)
X-Rspamd-Queue-Id: 810216C59A
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.94 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.997,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[];
 NEURAL_HAM_SHORT(-0.94)[-0.942,0]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2019 14:54:06 -0000

On Fri, Jun 21, 2019 at 01:52:01PM +0000, Christoph Moench-Tegeder wrote:
> New Revision: 504800
> URL: https://svnweb.freebsd.org/changeset/ports/504800
> 
> Log:
>   cad/kicad-doc: online help files and documentation for cad/kicad

Sorry, but I'm afraid it was badly reviewed.

> +MAINTAINER=	cmt@FreeBSD.org
> +COMMENT=	KiCad Online Documentation/Help Files

Comment is confusing ("online" typically means one does not have to
install anything locally, that makes it "offline")...

> +++ head/cad/kicad-doc/pkg-descr	Fri Jun 21 13:52:01 2019
> @@ -0,0 +1,3 @@
> +This port installs the official KiCad schematic symbol libraries.

... and does not align well with the port description.  The latter is
also expected to be more elaborate.  Your current pkg-descr is what the
COMMENT line should be.

> +PLIST_SUB=	PORTDOCS=""

Why not simply remove %%PORTDOCS%% from the pkg-plist if you're setting
it to an empty value unconditionally?

> +NO_ARCH=	yes

This knob should appear earlier.

./danfe