From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jan 26 02:20:01 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 852C0BBB for ; Sun, 26 Jan 2014 02:20:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 605671D3A for ; Sun, 26 Jan 2014 02:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s0Q2K1Hn018721 for ; Sun, 26 Jan 2014 02:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s0Q2K1FQ018720; Sun, 26 Jan 2014 02:20:01 GMT (envelope-from gnats) Resent-Date: Sun, 26 Jan 2014 02:20:01 GMT Resent-Message-Id: <201401260220.s0Q2K1FQ018720@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Daniel Herring Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0C66BB1D for ; Sun, 26 Jan 2014 02:17:53 +0000 (UTC) Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EC4141D2B for ; Sun, 26 Jan 2014 02:17:52 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id s0Q2HqFY032487 for ; Sun, 26 Jan 2014 02:17:52 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id s0Q2HqkO032473; Sun, 26 Jan 2014 02:17:52 GMT (envelope-from nobody) Message-Id: <201401260217.s0Q2HqkO032473@oldred.freebsd.org> Date: Sun, 26 Jan 2014 02:17:52 GMT From: Daniel Herring To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/186115: patch for pthread_mutex_unlock bug in nspluginwrapper X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 02:20:01 -0000 >Number: 186115 >Category: ports >Synopsis: patch for pthread_mutex_unlock bug in nspluginwrapper >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jan 26 02:20:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Daniel Herring >Release: 10.0-RELEASE >Organization: >Environment: FreeBSD strider2 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: nspluginplayer in the nspluginwrapper port was failing due to a bad pthread_mutex_unlock. Some web searches found the same bug for other OSes. It appears that the GTK+ API has changed. This patch fixes the problem. >How-To-Repeat: nspluginplayer --verbose type=application/x-shockwave-flash src=test.swf test.swf does not need to exist, but a valid plugin is required. I found this bug while trying to diagnose an incorrect flash plugin install. To enable debug and see the offending function call, this port requires some manual edits to the Makefile to enable debugging. I forgot to save the diffs. My memory is changing "--enable-strip" to "disable-strip" in CONFIGURE_ARGS, and adding "-g" to CFLAGS. >Fix: # cd /usr/ports/www/nspluginwrapper # make clean # make patch edit work/nspluginwrapper-1.4.4/src/npw-player.c @@ -2666,11 +2666,8 @@ } } - if (g_backend == BACKEND_GTK) { -gdk_threads_enter(); + if (g_backend == BACKEND_GTK) gtk_main (); -gdk_threads_leave(); -} for (i = 0; i < plugin_descs->len; i++) { # make # make install >Release-Note: >Audit-Trail: >Unformatted: