From nobody Sun Dec 5 17:16:29 2021 X-Original-To: ruby@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EB80318942AB for ; Sun, 5 Dec 2021 17:16:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J6YBP4TfXz4VZg for ; Sun, 5 Dec 2021 17:16:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 763441B7E5 for ; Sun, 5 Dec 2021 17:16:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1B5HGTwC092493 for ; Sun, 5 Dec 2021 17:16:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1B5HGTj0092492 for ruby@FreeBSD.org; Sun, 5 Dec 2021 17:16:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ruby@FreeBSD.org Subject: [Bug 258108] [exp-run] devel/ruby-gems: Update to 3.2.30 (Fixes for Ruby 3.0) Date: Sun, 05 Dec 2021 17:16:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: tj+freebsd_ports@a13.fr X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ruby@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? exp-run+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Ruby discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ruby List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ruby@freebsd.org X-BeenThere: freebsd-ruby@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638724589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hd853vpEu5Eewu+1pjc4dw5MVCw9r+iXgEppJEnsdKU=; b=giSB2EHSZwaa7I/HhmRIzYRgrR/SznsxbD57W935HPxzTZSR+c01qAv8i09B7Zfc2Yuw1n Ig1S13E9S3VL7WLyd+JtS5RzZrPedXC0UgBbpDlrdArcKvr2C3dMliam4oPK5pPLkIyDwJ mPbq9vZXxOemRg/ONbSvoYCEQHtL7M98x9o+T8kiYyKqZb2ZaPxqX/IOiDWPLwgCnTIO5V 1OaKYuCyZ+VjEXzgz2baDzXpc7SxUFWtP/5N/GwffQ7Mk8fKZej0sJf7dsum8R1BdXwkGi wVxKK4m4mYoSw1f4TZyYepnbYa5rUPu/5PMH1RTUklL/b0lK6HU4U3FV//e9ww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638724589; a=rsa-sha256; cv=none; b=fQZvADSR4FPfb8Fq03Y+oGlQhAUGlFu7i+bkC9xTnx37ejOmtm7j1/V0K8SjvtVygO3buO wJmZJ28LCnD4203W3lI6hlWC55Ctt4fhQPqxNlUUvHPUhH+yCF1ggs+KLGJ58RXzc8z57V WAJUwq5FIzEWOhnGgxUoOK322zKdvxziU+77kPWXTGMMPWLJ5BkFS+b7jI+70TFNWiuZRa PZEWcOjHeMXnrqGa4OfeYvSO0aBc1XLnP6md6eqhait5vi+dRWTnHQU0pEr+mMF4PlguKH of5OSve03RS5TW3DS4+SDZ4ucN87T84xWwmPZewm6Eao91cSKtXJ1/HZ9+owHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258108 --- Comment #40 from Thibault Jouan --- About updating/committing a patch: The issue here as I understand, is that once a patch is attached we have to check it with exp-run, then wait for review, approval and commit it (Comment #34). But understandably, the exp-run and adjustments on the patch take some time, reviewing it too, and by this time some gem ports affected by the patch have been updated. I'm happy to update the patch as many time as needed but: * I don't want to give unnecessary work to people (Antoine Brodin for exp-run for example); * I don't have a workstation with the availability and build power to rebuild *all* ports depending on RubyGems fast enough before the gem ports get updated (I mean trying to do exp-run on my machine is not really possible event if I limit ports to the ones depending on RubyGems). Anyway I will make a new update, but not before one or two days at least. In the meantime, if you don't use any of the gems where the FreeBSD port patched the gem specification file, then you can ignore the failure and keep the version currently in the port tree. It won't affect devel/ruby-gems itself, nor any gem installed with `gem install ...`. This is slightly unrelated, but a thing that could help is to get rid of those gem specification patches. Just an idea but ideally, maintainers of the FreeBSD port could convince gem author to fix version specifications in dependencies, so that we wouldn't need patches in the port (I'm pretty sure it was done, but don't know to which extent). I also know that a dedicated feature for this was discussed upstream (to avoid patching), but IIRC wasn't very popular (because ideally gems should be fixed directly). About RubyGems setup command `--destdir' and `--no-regenerate-binstubs' options (Comment #36 and Comment #38): The original issue regarding executable wrappers in combination with `--destdir' is from RubyGems 2.7.0 if I'm correct (909b5fb8). I reported it by mail with a possible fix to the author, but got a rude answer at the time. It was later possible to workaround this with 4619f13a, we have to pass `--no-regenerate-binstubs' explicitly. This is similar to the more recent `--no-regenerate-plugins' and `--format-executable' which we must now pass explicitly to the setup command for success. One of the places where this was discussed later is here: https://github.com/rubygems/rubygems/issues/2370 With a normal installation of RubyGems, there cannot be any executable wrapper to rewrite (or any plugin wrapper) since we need RubyGems to install gems, so it happens before we could have a gem installed. The kind of manual update that was explained in the GitHub issue, or shown with rake gem in Comment #38 only affects some RubyGems developers and maintainers if I understand correctly, and only when "experimentally" installing RubyGems manually over an existing installation. End users should never encounter this scenario. I only noticed it (years ago) because of the behavior being the default, while attempting to update the port, because the name of the environment variable to enable bundler changed, and because the build system was warning about things not installed where they should be. The conditions to trigger it are very specific. IMO all people maintaining RubyGems ports introduced `--no-regenerate-binstubs' in their build at the time, and wont use the code path where that last remaining bug may be. What would help is if following similar features were "opt-in" instead of "opt-out" (I guess we cannot change actual ones in 3.x again, to avoid breakage). --=20 You are receiving this mail because: You are the assignee for the bug.=