From nobody Wed Apr 27 22:14:49 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4B93B1993B5C for ; Wed, 27 Apr 2022 22:15:02 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic303-25.consmr.mail.gq1.yahoo.com (sonic303-25.consmr.mail.gq1.yahoo.com [98.137.64.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KpY2s1rXlz4R8V for ; Wed, 27 Apr 2022 22:15:01 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1651097694; bh=cug28FFakzM+34dWviZlotSNDH5R6SIt/a31BWGpbeI=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=HQTQ1QeyHrUTrBwzCpWvH3nDuSouEgR/ihM/MVxIJMWP5kGb26p4SXTtSOPaFLSuf5HLkWXL4eRUkxIoqG9WlYeWGhs7f/kTqpJriTS3+fWORu6bdp2qKpvan9q7s2JXokHpG0Ai74DPnLQfRoH+xRMCRb8IJTMtTgUYEkZlx9hTuMGJsa/kZJDk2ffNB2IIuqU9LspE9LyFvytyOLss63/RrBAMjEe7dh9X6zHv75799USCP0k3n1e88pojVz/Fv48bsqftKq+xVBObfq0Cblf3bZHTtnN+mqV3C5Gnod9X4s5eCLm6IorxeUKTGuS25lDNm/nPiRZhCmZ2ewWhrQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1651097694; bh=gtN7HJ3rvowg4nhrV2Cj3hMNPyhJOhHYFfi7g6ubioW=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=iUvtDZUmCwn1kwNFlDO1w5vHjEBsQtG07tP1GEFYrpRZFXTrBR2uFOJYudWuLbqEHcPXREhEFLDuTwFfhiWy5XiuXwfYWn+ypMJhkMNKJsjlVj3qqFhAWm9oCdus/QC6X7Mb/zNEfH69egG3yBldyVOJCi3IwYsiiA2U+Ryz29rm2FZk78ePF0O/bWxW8tmCqMlxZ6kY+3XCxKsUKfZ+Ad30QwtcLaTQp0mtXMl+5dOnFzLzQC9SNP93IS9k7AujHRp0R7bIriEedR3zREdbBySZzvwrbZ3VNvpug22SjLPrZfqoHC8oAnH4e1n4AQ3/d5rAABlhUQr5ySg1AoOQVQ== X-YMail-OSG: XDqwKFUVM1nC3cCRRuB0ype48XAijzhbjHMqV.eY2Ul25g4KFjT6w7sy1Tp23eY 9bH9_.oc5MqEGVamyNUg6gH3U1lHf4jtsT631Q0MvaSlrXP2xxQg4MakZcASdcxlVqrVLvlRuQIL yM47GOhlSn74TfnJ26wdgwx31YeeuOdgTdnjgkA48HBEivC.UVLixAby0.wvpr5v5d9o7tu73eun ihwLZkhgzuncBXHcNpHrm_7lYKm23YiXWpQ3WfB8S7KpWWYJNS.xS6NPmcgMaogflO8SpohW7cgl pundRdeKjLnWlUO1S6AsH13iKagWyqi37KUFKHp5bnbbbmcDL2Pb3cP_vDNVPuGfTjw7Vw_0IP5n eTalJlIjsLa6Dcyp5pde_egz3Qu3bc5X2P1duIEazpV4oCCW5I5gUyMWe72iaCvn53TauKop31Eq xwtUPvu5_XnmADyzjHDlvmeU_frERf4088W0uWXGR_oeAhE.1hQXem6Vb7c5hfd_j.s6cV3LGuJW Wv0ME9Mk4JtFCLzW9pvdEeIvuJsENY9wVyoGI3H5Bqnnmei23fHQ9GRirrytymfF1rmd55x6AKuA .MG3l8_.3hAbcCtQxAKIi6IABgExYHSxFYxjNhTd1R3xYT9lqvpVoNfGaa2b7Qa6KomRm3T2Jgdf 4083V9zy06o4Qf3c5_5xiXdrTEavFlEzdsunASaMPEEfBGQKqjEzUJSTWWKn.p8zCUP7CKwVZ1zi pgLbzLw7k7Nnxu3SlJ9IeEjKlJCEBxYWAepHC5fXkae_fBK1det1hBHynilDOhArdtu0yOlw69Wx oK.YbtKBk.PkrQBB1ma0PX2lRBfu.ki4ykN7vUhCLHRulNBQUOPieRUWlflUw7sKwIWz_9.nS_NA NewAQgEly6g_zZ3ie.NxWDXDQS71epcEFqjOIz.kivbCW1GydKgM787lMxdodUBP59wxqDe_lZ93 ZpgY03W7hThA5BTMhhvnFTJGDM959fr4KKeVu8I3tdpFUT3SLt9aqen.qh0mW6yjnxPtKB6425Ia tIvrSF7tzzCFW151Ss5MTIV1Dpqj5SfgzZJqKFwvlQcJKlIwRTZlGco9Hvbj2CL_qoBrcInMue.2 OxBNxdu6sjRf8nLd_1wxR65KhpIt6Qhi8vJ2Kou.u8I3N98FPDs2GzhSpxzy464lw4fShcskNCCL PLWG0I3XU3jQmDdQuBQjkHff57mbSqyoTZHgSXwxMRxiK20lo82gjmpw3qptFuuK2FHfO51fvhsM YUZUVTFh9BkI1zpQoD7QaNkSWdQJgD94SjKgsXVdcW_90Y1xYXJ6NzoK0VefF7OIdCfv9Kbu2o4I jw630LR7ysKGG29jdyavHATssJh8_ZNun.9g0a5jZ5sX5nTOwDCX6PsT4Z4aBdUid1YHJC0bYbGV JjjXQgReoGm1AQLTdt1tpqOUM4P38RtWRolrWAXsakgiZz3gvPkEvSWr3qGDmOTVTt0ra_KBLj5C 1GrO8mF20gTG3GxVDlRV7AWVfKM5ANUIqszEk83Clx0Kh2gAo_vGxDMjHOo.2msYVTfN8LUuNM8z _7QBdsk52Czi6NtEyefKnEN8cyEc2GTCSft9zXaRUcqCwbDqp1pXrm94g3dBL8AW9NpnaegyiDr9 gwuPJLPKYTyfxNvdfqXOJma8wAwsBIe_a7Lh5xF52.AUXR4xvrIlZErzequ2VeME32dcaRhwvaA3 iqrWfpa8vVTp2dz0.P0kiRfa7_GDuyy4UzWV9Z4DUnQ6aRhYydQA6kbODi3IAqtbCXMSHjHmPTun 6_FNOcLgQsWQ1NVr.OQ1ue0ax0feXHbIo0X1uwV_.pYDgTJ9ig38ud.8kdVW2A6Q4s.DfIIh3xhj mtbpqAFnm_RyVDi2XnaS5eIh_BuWj7zoxP97gyLvvjL1hkc2I4eblUtSBsVwH.2sFee5RhVaK0Ti 2W.dQHbzq_QlEhS5ZDNvEleetgjNKKtv6I6l1tEP0QwzNGa8gjNlxkjteqdIIpEjVooVQd_MeYwy 15WePaPPFHwAR4RG1Sf5KtMXe_tWKZ7sRr0zvizUU2g7ApwjMCt4CvquiDQYX5YSI_gXsMxkVWDg mNtnCXVSkrP6wyIcMqMWkD45.DdVqQz7MV_RtoxXxSBlIPWjVeSB4_PdlU_JE08HKAbX3lnsJyEm jipuKhRa0v63Wzzy4PRGBZPzs58pPKbLIdnCFkkZKhmjO3zELdkkTkAjyr5PtKjed.FO.Ydi43p0 CeMmE0BaPfa.aHGcsDTGbIKEW29Vw_i1Vx6KJcWZZHqefeEIId2wJJpiEBrhMfJOkjsA3jSspEh5 e1LkXVld6rhE- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Wed, 27 Apr 2022 22:14:54 +0000 Received: by hermes--canary-production-bf1-5f4c6455f8-b7pn2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e5287cb5ab9bd71526b702c07445b0f9; Wed, 27 Apr 2022 22:14:51 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: b40c0db6f6d6 - main - Patch up __diagused for when only one of INVARIANTS or WITNESS is defined Message-Id: <775952BB-DEE3-4052-BF42-D04A7A672C22@yahoo.com> Date: Wed, 27 Apr 2022 15:14:49 -0700 To: "mjg@freebsd.org" , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3654.120.0.1.13) References: <775952BB-DEE3-4052-BF42-D04A7A672C22.ref@yahoo.com> X-Rspamd-Queue-Id: 4KpY2s1rXlz4R8V X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=HQTQ1Qey; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.206 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-3.45 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-0.95)[-0.954]; FROM_HAS_DN(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.206:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MLMMJ_DEST(0.00)[dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim] X-ThisMailContainsUnwantedMimeParts: N Just a suggestion . . . For: QUOTE +#elif ((defined(INVARIANTS) && !defined(WITNESS)) || \ + (!defined(INVARIANTS) && defined(WITNESS))) #define __diagused __unused END QUOTE something like the following seems far more direct to me: +#elif defined(INVARIANTS) != defined(WITNESS) #define __diagused __unused Boolean == and != are well defined, even in languages where Boolean is fully distinct from numeric types. Expressing everything via NOT, AND, and possible OR makes various notations messy for simple concepts. Hardware folks call != by the name XOR instead of inequality. Equal length "vectors" of Booleans have != and XOR being distinct, XOR being a "Booleanwise" (bitwise) != producing a vector of Booleans, the resulting vector again being of matching length. By contrast != for equal length vectors of Booleans producing just one overall Boolean for if the count of non-matching Booleans in an XOR would be positive (TRUE) vs. zero (FALSE). Food for thought. === Mark Millard marklmi at yahoo.com