From owner-cvs-all@FreeBSD.ORG Sun Jun 27 23:52:32 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B220916A4CE; Sun, 27 Jun 2004 23:52:32 +0000 (GMT) Received: from mgr2.xmission.com (mgr2.xmission.com [198.60.22.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8580943D2D; Sun, 27 Jun 2004 23:52:32 +0000 (GMT) (envelope-from glewis@eyesbeyond.com) Received: from [198.60.22.206] (helo=mgr6.xmission.com) by mgr2.xmission.com with esmtp (Exim 3.35 #1) id 1BejRo-0006U0-02; Sun, 27 Jun 2004 17:52:32 -0600 Received: from [166.70.56.15] (helo=misty.eyesbeyond.com) by mgr6.xmission.com with esmtp (Exim 4.32) id 1BejRn-0007OH-QZ; Sun, 27 Jun 2004 17:52:32 -0600 Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) i5RNqUYr036366; Sun, 27 Jun 2004 17:52:30 -0600 (MDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.12.11/8.12.11/Submit) id i5RNqTMu036365; Sun, 27 Jun 2004 17:52:29 -0600 (MDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Sun, 27 Jun 2004 17:52:29 -0600 From: Greg Lewis To: Kirill Ponomarew Message-ID: <20040627235229.GA36136@misty.eyesbeyond.com> References: <200406271812.i5RICLjj014328@repoman.freebsd.org> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <200406271812.i5RICLjj014328@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Content-Type: text/plain; charset=us-ascii X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on mgr6.xmission.com X-Spam-Level: X-Spam-Status: No, hits=-4.9 required=8.0 tests=BAYES_00 autolearn=no version=2.63 X-SA-Exim-Connect-IP: 166.70.56.15 X-SA-Exim-Mail-From: glewis@eyesbeyond.com X-SA-Exim-Version: 4.0 (built Sat, 24 Apr 2004 12:31:30 +0200) X-SA-Exim-Scanned: Yes (on mgr6.xmission.com) cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/math/gnuplot Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jun 2004 23:52:32 -0000 On Sun, Jun 27, 2004 at 06:12:21PM +0000, Kirill Ponomarew wrote: > krion 2004-06-27 18:12:21 UTC > > FreeBSD ports repository > > Modified files: > math/gnuplot Makefile > Log: > Fix OPTIONS > > PR: ports/68388 > Submitted by: Ports Fury So, what exactly is wrong with doing .if defined(WITH_OPTION) stuff .else other stuff .endif that .if defined(WITHOUT_OPTION) other stuff .else stuff .endif fixes? The only thing I can think of is that it may be prefered to test the WITHOUT_OPTION variable when the default is on. Is that it? Also, why wasn't the PR assigned to the maintainer (me :)? -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org