Date: Wed, 28 Jan 2015 16:37:44 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Alexander Kabaev <kabaev@gmail.com> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, svn-src-projects@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r277803 - projects/clang360-import/lib/clang/include Message-ID: <2DA71591-EE38-42F9-983F-8E711CA36A75@FreeBSD.org> In-Reply-To: <20150128091457.1b0ea3a7@kan> References: <201501271925.t0RJPem3010417@svn.freebsd.org> <CAJ5_RoAvww7xFsSTBMPDThYsbpVbxOs11nWE=eEXpJRFx_kyww@mail.gmail.com> <20150127191134.4fe3a17f@kan> <F7477A20-BC56-4CF9-8520-77F7BFD4B72E@FreeBSD.org> <20150128091457.1b0ea3a7@kan>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_5580942F-B39E-4DB7-B01B-8852B719CE4F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 28 Jan 2015, at 15:14, Alexander Kabaev <kabaev@gmail.com> wrote: > > On Wed, 28 Jan 2015 08:42:48 +0100 > Dimitry Andric <dim@FreeBSD.org> wrote: ... >> I'm not sure what the problem is with storing a compiler's >> internal-only headers in the location where upstream expects them to >> be? Note that gcc does something similar; for example with the gcc49 >> port, it stores all its internal headers under: >> >> /usr/local/lib/gcc49/gcc/i386-portbld-freebsd11.0/4.9.3/include >> >> While I do agree that this is not a pretty-looking path, upstream has >> chosen it to be like this, and there are most likely good reasons for >> it. As for clang, I just want to get rid of as many "FreeBSD is a >> special snowflake" patches as I can. > > Nobody _expects_ them to be there, for they are internal and not > directly addressable by anyone. We can tweak locations as we see fit > with no user visible consequences. What you destroy by this is the nice > property we had to date - all of the base headers could be searched by > simple grep on /usr/include and no obscure directories need to be > remembered. First you say "they are internal and not directly addressable", and in the next sentence you say that it is a "nice property that you could search by grepping /usr/include". If the files are internal and not directly addressable, why would you ever want to search them? In that respect, it is even better to relocate them to a different location than /usr/include, since they're not *FreeBSD* headers, they're clang internal headers. In other words, I consider this a win, not any form of loss. :) -Dimitry --Apple-Mail=_5580942F-B39E-4DB7-B01B-8852B719CE4F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTJAksACgkQsF6jCi4glqN8ZACgpfjkrmL2V+6+1xfCiLXG2vLO xrYAnRN80dy5cCS/VZL66KLZFbBtbUh2 =pnci -----END PGP SIGNATURE----- --Apple-Mail=_5580942F-B39E-4DB7-B01B-8852B719CE4F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2DA71591-EE38-42F9-983F-8E711CA36A75>