From owner-freebsd-ia64 Sun Dec 29 8:31:18 2002 Delivered-To: freebsd-ia64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA47237B401; Sun, 29 Dec 2002 08:31:17 -0800 (PST) Received: from espresso.q9media.com (espresso.q9media.com [65.39.129.122]) by mx1.FreeBSD.org (Postfix) with ESMTP id 664D343EE1; Sun, 29 Dec 2002 08:31:17 -0800 (PST) (envelope-from mike@espresso.q9media.com) Received: by espresso.q9media.com (Postfix, from userid 1002) id 248B29C10; Sun, 29 Dec 2002 11:20:38 -0500 (EST) Date: Sun, 29 Dec 2002 11:20:38 -0500 From: Mike Barcroft To: Mark Murray Cc: Bruce Evans , Matthew Dillon , current@FreeBSD.ORG, ia64@FreeBSD.ORG Subject: Re: ia64 tinderbox failure Message-ID: <20021229112038.D98334@espresso.q9media.com> References: <20021229004907.C98334@espresso.q9media.com> <20021229184137.C40787-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021229184137.C40787-100000@gamplex.bde.org>; from bde@zeta.org.au on Sun, Dec 29, 2002 at 06:51:07PM +1100 Organization: The FreeBSD Project Sender: owner-freebsd-ia64@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Bruce Evans writes: > The correct fix is to unbreak getbsize() so that it takes an `int *' as its > first arg like it used to. The interface change and the above change > just give a header length that is not directly usably by any of its users. > The header length is what must be passed to printf in %*s formats; it > should have type int since that is what printf takes; any bounds checking > of it belongs in getbsize() (but in practice it is a small positive > number since anything else would give preposterous formatting, so there > is never a problem with its bounds). Other users of getbsize() in the > src tree but perhaps not ones in ports have been broken to match the > interface breakage. The usual breakage is to cast the size_t to int > without checking bounds. Agreed. Not a single consumer actually wants a size_t and not all base system uses have been "fixed" for the new interface (ls(1) for instance). I'd like to see the interface restored and merged into RELENG_5_0 before we introduce this mistake on the world. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ia64" in the body of the message