From owner-freebsd-stable@FreeBSD.ORG Thu Jul 2 20:08:29 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9DDC71065673; Thu, 2 Jul 2009 20:08:29 +0000 (UTC) (envelope-from mandrews@bit0.com) Received: from magnum.bit0.com (magnum.bit0.com [207.246.88.226]) by mx1.freebsd.org (Postfix) with ESMTP id 6A50F8FC13; Thu, 2 Jul 2009 20:08:29 +0000 (UTC) (envelope-from mandrews@bit0.com) Received: from localhost (localhost [127.0.0.1]) by magnum.bit0.com (Postfix) with ESMTP id 8E966A264; Thu, 2 Jul 2009 16:08:28 -0400 (EDT) X-Virus-Scanned: amavisd-new at bit0.com Received: from magnum.bit0.com ([127.0.0.1]) by localhost (magnum.int.bit0.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VrH5W+KWvSfE; Thu, 2 Jul 2009 16:08:26 -0400 (EDT) Received: from beast.int.bit0.com (beast.int.bit0.com [172.27.0.2]) by magnum.bit0.com (Postfix) with ESMTP; Thu, 2 Jul 2009 16:08:26 -0400 (EDT) Date: Thu, 2 Jul 2009 16:08:25 -0400 (EDT) From: Mike Andrews X-X-Sender: mandrews@beast.int.bit0.com To: Danny Braniss In-Reply-To: Message-ID: References: <20090630155437.GA42783@a91-153-125-115.elisa-laajakaista.fi> <4A4A6358.1010806@bit0.com> <20090701090818.GA1391@a91-153-125-115.elisa-laajakaista.fi> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Rick Romero , Jaakko Heinonen , freebsd-stable@freebsd.org, Andriy Gapon , Gavin Atkinson Subject: Re: kern/135412: [zfs] [nfs] zfs(v13)+nfs and open(..., O_WRONLY|O_CREAT|O_EXCL, ...) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2009 20:08:29 -0000 On Wed, 1 Jul 2009, Danny Braniss wrote: >> On 2009-06-30, Mike Andrews wrote: >>> Jaakko Heinonen wrote: >>>> On 2009-06-30, Danny Braniss wrote: >>>>> This pr is realy holding me back, I can't upgrade this server, and >>>>> telling serveral tens of users to us cp, etc is not an option. The open >>>>> works fine if not using O_EXCL. >>>> >>>> I guess that r185586 needs to be MFCd to stable/7. Here's an untested >>>> patch against stable/7: >>> >>> The patch doesn't help over here, sorry. >>> >>> Simply doing 'touch' or 'mv' to an NFSv3 mount (using either a v6 or v13 >>> zpool) is the test case I've been using; touch doesn't even use O_EXCL as >>> far as I can tell. >> >> I could reproduce the problem with O_EXCL and verified that the patch >> fixes it. However I couldn't reproduce the problem you are seeing with >> touch and mv. > > same here, touch worked before too - so i think it's unrelated, > btw, it seems that the problem does not exist on i386, though > I'm pretty sure I tried there too, oh well, > > thanks! > danny I'm not sure if what was commited to stable/7 yesterday is substantially different from that patch (and if not, what in the world I was doing wrong/stupid in testing), but everything now works for me... thanks :)