From owner-cvs-src@FreeBSD.ORG Thu Feb 22 17:17:37 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0A53B16A404; Thu, 22 Feb 2007 17:17:37 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay01.kiev.sovam.com (relay01.kiev.sovam.com [62.64.120.200]) by mx1.freebsd.org (Postfix) with ESMTP id 93CB113C4A5; Thu, 22 Feb 2007 17:17:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.227] (helo=fw.zoral.com.ua) by relay01.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.60) (envelope-from ) id 1HKHZO-000OIh-Dp; Thu, 22 Feb 2007 19:17:35 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.4/8.13.4) with ESMTP id l1MHHKKg010026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Feb 2007 19:17:20 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8) with ESMTP id l1MHHKmo053294; Thu, 22 Feb 2007 19:17:20 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8/Submit) id l1MHHKxO053293; Thu, 22 Feb 2007 19:17:20 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 22 Feb 2007 19:17:20 +0200 From: Kostik Belousov To: John Baldwin Message-ID: <20070222171720.GI39168@deviant.kiev.zoral.com.ua> References: <200702191056.l1JAuASc059200@repoman.freebsd.org> <200702191839.58671.jhb@freebsd.org> <20070220144936.GY39168@deviant.kiev.zoral.com.ua> <200702201122.00390.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8MD1ZCO3r6aZNHwn" Content-Disposition: inline In-Reply-To: <200702201122.00390.jhb@freebsd.org> User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: ClamAV version 0.88.7, clamav-milter version 0.88.7 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-0.1 required=5.0 tests=ALL_TRUSTED,SPF_NEUTRAL autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on fw.zoral.com.ua X-Scanner-Signature: 6dc4245230f22f3abb357b69a6da667e X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 802 [Feb 22 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2007 17:17:37 -0000 --8MD1ZCO3r6aZNHwn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 20, 2007 at 11:21:59AM -0500, John Baldwin wrote: > On Tuesday 20 February 2007 09:49, Kostik Belousov wrote: > > On Mon, Feb 19, 2007 at 06:39:58PM -0500, John Baldwin wrote: > > > On Monday 19 February 2007 05:56, Konstantin Belousov wrote: > > > > kib 2007-02-19 10:56:10 UTC > > > >=20 > > > > FreeBSD src repository > > > >=20 > > > > Modified files: > > > > sys/kern vfs_syscalls.c=20 > > > > Log: > > > > Remove union_dircheckp hook, it is not needed by new unionfs code= anymore. > > > > As consequence, getdirentries() no longer needs to drop/reacquire > > > > directory vnode lock, that would allow it to be reclaimed in betw= een. > > >=20 > > > I think there is at least one more copy of getdirentries() under sys/= compat, > > > possibly multiple. Are you going to fix this in all of them? > >=20 > > Could you, please, point out where is it ? My grep told me that I remov= ed > > all references to the union_dircheckp, and I think that getdirentries()= code > > had to have references to it. My change modified two syscalls: getdiren= tries() > > and ogetdirentries(). >=20 > Well, I did find at least 3 ABIs (Linux, svr4, and ibcs2) that do their o= wn > wrapper around VOP_READDIR(), but none of them had the union check in the= m. As result, "mount -o union" does not work for compat binaries. > Do you know why the ABIs use cookies for VOP_READDIR() but getdirentries() > doesn't? No, and it seems that cookies, as well as vfs_syscalls.c avoidance of cooki= es (together with union_dircheckp) go back to at least 1994/1997 years, and Lite-2 import (see commit logs for rev. 1.9 and 1.54 of vfs_syscalls.c). --8MD1ZCO3r6aZNHwn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF3dAfC3+MBN1Mb4gRAlTdAKDf7H5jwhmfJdNS7/yYxGhgvDNg3gCffIrP 7xyL5PXPsxM3AuSX7IO/TTM= =4g2Q -----END PGP SIGNATURE----- --8MD1ZCO3r6aZNHwn--