From owner-svn-src-all@freebsd.org Mon Oct 16 15:56:46 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DFA42E3DDCC for ; Mon, 16 Oct 2017 15:56:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A96CBF67 for ; Mon, 16 Oct 2017 15:56:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id c3so1816666itc.3 for ; Mon, 16 Oct 2017 08:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=fYDjhcKUnHc0eEOHovu2GvPSXGfsfXxsgR11OK/mFdg=; b=NvlHQk7Cw9uTUgJ+kTVfaAB+pw7rnyAJBvc8Shmci2G+2sIMB7bGpdmdR2t4/GMkYB 6eaoq9yPWS2h8PywqguZAJy26Z3GEvdrDJyN+Gbx+fq/vH99fYBDA52vfDL1lDyBq3eD znypPQKKa2Ww2k36SU9f+ymj9kciZSwboTaPSV3z5W5wrEdBY58kKUk56dULyxpjQfbJ nmChLVqHOZYFBy5AXtpsa/URZogEZmxo66YpqvKPXCmxnl6s5FC3KRTna/p/VmXJdaFW kiy/5XyWlwH0YUGuL8/I5SOvKBZrEraXnHnuea4XXf0Jp9y5pdYzb00j/p6s8uLGRK6y lYQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=fYDjhcKUnHc0eEOHovu2GvPSXGfsfXxsgR11OK/mFdg=; b=W/x93oVXHLYnJYccoUKxO/o0SsaHmdC5ZGIMbSAsq9z0wGmnojPzTqLlWJVYC967xJ o64wSz+h7XV2K0AUbF/r5kCuPBSUd556FF+toavpKdrwRGOFxdmZckZdMkKiVAsX3N+5 c0+VUlFSoWhbd3UtPWdgGDGnnXvQmCkYmPU3F39dw/XyQC1o/j4i8uEBj62rq6/Vlj1K /hCb4vb+04nRxP0zC5ENn9N4foEfYMdbgeoVoyQl+YScQQhyeLxbkkvnH5nMVjYVXJm5 Y2AR5E2Wl6D6cf74215DXZmrP1NfepckTYZjhbuoFvZeRaUR/7QcjL0a3mVoXZXADiil k+qg== X-Gm-Message-State: AMCzsaWPM8W9d50f9y3hxrkwi72oyE+r7p0zp5mLRGoib9U6xkpp/Mxx 2Fsqts1LhjDLBoaSlnamolWSN2p2ZPfKcd9ANfOtLA== X-Google-Smtp-Source: ABhQp+QaC9vll1bENoDPZkkTstrdYVjJPnwgIIZ/uYR5TE2mHpsmpVn6q1TyVrAGpFD3ZtSU9arHWUy9ReJ2lhMMinQ= X-Received: by 10.36.94.129 with SMTP id h123mr1563486itb.64.1508169405833; Mon, 16 Oct 2017 08:56:45 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.94.130 with HTTP; Mon, 16 Oct 2017 08:56:45 -0700 (PDT) X-Originating-IP: [50.253.109.65] In-Reply-To: References: <201710160359.v9G3xCCi087576@repo.freebsd.org> From: Warner Losh Date: Mon, 16 Oct 2017 09:56:45 -0600 X-Google-Sender-Auth: tGUgq87TvuoF-9I0ZPcgVuf6OT0 Message-ID: Subject: Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader To: Andrew Turner Cc: eric@meatspace.com, src-committers , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Warner Losh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 15:56:47 -0000 So this is on aarch64? Is this running a standardish qemu setup as documented on https://wiki.freebsd.org/arm64/QEMU ? Or are there tricks that we need to cope with... If we can't get good resoltuion on this today, I plan on backing out the entire change. Warner On Mon, Oct 16, 2017 at 9:38 AM, Andrew Turner wrote= : > I have a local Jenkins setup that builds images & tries to run under > various simulators. The final image is built with mkimg. I=E2=80=99m runn= ing it > under qemu. > > Andrew > > On 16 Oct 2017, at 13:19, Warner Losh wrote: > > I'll take a look, but I've also ccd Eric so he can figure out what went > wrong with is code in your environment. What env is That? > > Warnee > > On Oct 16, 2017 3:26 AM, "Andrew Turner" wrote: > >> >> > On 16 Oct 2017, at 04:59, Warner Losh wrote: >> > >> > Author: imp >> > Date: Mon Oct 16 03:59:11 2017 >> > New Revision: 324646 >> > URL: https://svnweb.freebsd.org/changeset/base/324646 >> > >> > Log: >> > Unify boot1 with loader >> > >> > Refactor boot1 to use the same I/O code as /boot/loader uses. Refacto= r >> > to use the common efi_main.c. >> > >> > Submitted by: Eric McCorkle >> > Differential Revision: https://reviews.freebsd.org/D10447 >> > >> > Added: >> > head/sys/boot/efi/libefi/efi_main.c (contents, props changed) >> > - copied, changed from r324645, head/sys/boot/efi/loader/efi_main.= c >> > Deleted: >> > head/sys/boot/efi/boot1/boot_module.h >> > head/sys/boot/efi/boot1/ufs_module.c >> > head/sys/boot/efi/boot1/zfs_module.c >> > head/sys/boot/efi/loader/efi_main.c >> > Modified: >> > head/sys/boot/efi/boot1/Makefile >> > head/sys/boot/efi/boot1/boot1.c >> > head/sys/boot/efi/libefi/Makefile >> > head/sys/boot/efi/loader/Makefile >> >> Hello Warner, >> >> After this change I=E2=80=99m getting the following panic on various tes= t VMs. >> >> Andrew >> >> >> FreeBSD EFI boot block >> >> Loader path: /boot/loader.efi >> >> Load Path: \EFI\BOOT\BOOTAA64.EFI >> Load Device: VenHw(837DCA9E-E874-4D82-B29A- >> 23FE0E23D1E2,003C000A00000000)/HD(1,GPT,DD40E9C6-B247-11E7-A >> A0A-15EFE1BBB7CF,0x3,0x640) >> panic: Couldn't trim device path >> --> Press a key on the console to reboot <-- >> >> >