From owner-svn-src-all@FreeBSD.ORG Sun Jan 8 08:04:40 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EC7E106564A; Sun, 8 Jan 2012 08:04:40 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C6B428FC12; Sun, 8 Jan 2012 08:04:38 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA14950; Sun, 08 Jan 2012 10:04:36 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Rjnk4-0001Fm-4e; Sun, 08 Jan 2012 10:04:36 +0200 Message-ID: <4F094E11.4010007@FreeBSD.org> Date: Sun, 08 Jan 2012 10:04:33 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Xin LI References: <201201032017.q03KHZ0Z040723@svn.freebsd.org> In-Reply-To: <201201032017.q03KHZ0Z040723@svn.freebsd.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r229416 - head/sys/dev/tws X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2012 08:04:40 -0000 on 03/01/2012 22:17 Xin LI said the following: > Author: delphij > Date: Tue Jan 3 20:17:35 2012 > New Revision: 229416 > URL: http://svn.freebsd.org/changeset/base/229416 > > Log: > Don't forget to release queue lock when allocation of memory failed. > > Submitted by: Sascha Wildner > Obtained from: DragonFly > MFC after: 2 weeks > > Modified: > head/sys/dev/tws/tws.c > > Modified: head/sys/dev/tws/tws.c > ============================================================================== > --- head/sys/dev/tws/tws.c Tue Jan 3 19:47:32 2012 (r229415) > +++ head/sys/dev/tws/tws.c Tue Jan 3 20:17:35 2012 (r229416) > @@ -685,6 +685,7 @@ tws_init_reqs(struct tws_softc *sc, u_in > { > if (bus_dmamap_create(sc->data_tag, 0, &sc->reqs[i].dma_map)) { > /* log a ENOMEM failure msg here */ > + mtx_unlock(&sc->q_lock); At least here it looks like the new line has inconsistent whitespace indentation. > return(FAILURE); > } > sc->reqs[i].cmd_pkt = &cmd_buf[i]; -- Andriy Gapon