From owner-cvs-all@FreeBSD.ORG Mon Jan 22 14:15:23 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B267D16A400; Mon, 22 Jan 2007 14:15:23 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay01.kiev.sovam.com (relay01.kiev.sovam.com [62.64.120.200]) by mx1.freebsd.org (Postfix) with ESMTP id 5487013C457; Mon, 22 Jan 2007 14:15:23 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.227] (helo=fw.zoral.com.ua) by relay01.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.60) (envelope-from ) id 1H8yEd-000GZF-EK; Mon, 22 Jan 2007 14:25:24 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.4/8.13.4) with ESMTP id l0MCPA5a060011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Jan 2007 14:25:10 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8) with ESMTP id l0MCPAVB031657; Mon, 22 Jan 2007 14:25:10 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8/Submit) id l0MCP9G0031656; Mon, 22 Jan 2007 14:25:09 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 22 Jan 2007 14:25:09 +0200 From: Kostik Belousov To: "Bjoern A. Zeeb" Message-ID: <20070122122509.GB71333@deviant.kiev.zoral.com.ua> References: <200701221125.l0MBPMS4041567@repoman.freebsd.org> <20070122115230.J82671@maildrop.int.zabbadoz.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline In-Reply-To: <20070122115230.J82671@maildrop.int.zabbadoz.net> User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: ClamAV version 0.88.7, clamav-milter version 0.88.7 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-0.1 required=5.0 tests=ALL_TRUSTED,SPF_NEUTRAL autolearn=failed version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on fw.zoral.com.ua X-Scanner-Signature: f2683d8df775da069012ccac6e6e6321 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 701 [Jan 22 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/deadfs dead_vnops.c src/sys/kern vfs_lookup.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 14:15:23 -0000 --neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 22, 2007 at 11:53:50AM +0000, Bjoern A. Zeeb wrote: > On Mon, 22 Jan 2007, Konstantin Belousov wrote: >=20 > >kib 2007-01-22 11:25:22 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/fs/deadfs dead_vnops.c > > sys/kern vfs_lookup.c > > Log: > > Below is slightly edited description of the LOR by Tor Egge: > > > > -------------------------- > > [Deadlock] is caused by a lock order reversal in vfs_lookup(), where > > [some] process is trying to lock a directory vnode, that is the parent > > directory of covered vnode) while holding an exclusive vnode lock on > > covering vnode. > >.... > > To fix the LOR, ups@ noted that when crossing the mount point, ni_dvp > > is actually not used by the callers of namei. Thus, placeholder deadfs > > vnode vp_crossmp is introduced that is filled into ni_dvp. >=20 > which of the LOR #s on "The LOR page" can be marked "patched" with > this commit? >=20 > http://sources.zabbadoz.net/freebsd/lor.html None, your page lists only LORs that are detectable by WITNESS. This one is between lockmgr lock and vfs_busy(), both of them are invisible to WITNESS. --neYutvxvOLaeuPCA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFtK0lC3+MBN1Mb4gRAv6HAJ0cN41/ijkzx+k+izWdJQlUu9JcOgCcDxU2 AUNqBy9O8NEBorGBB1HqspA= =3jUK -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA--