From owner-freebsd-current Tue Nov 19 1:44: 6 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2955337B401; Tue, 19 Nov 2002 01:44:05 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35A4343E42; Tue, 19 Nov 2002 01:44:04 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gAJ9i2bq017356; Tue, 19 Nov 2002 10:44:02 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans Cc: Tim Robbins , Kris Kennaway , current@FreeBSD.ORG Subject: Re: Device permissions with DEVFS In-Reply-To: Your message of "Tue, 19 Nov 2002 19:01:46 +1100." <20021119184410.D29957-100000@gamplex.bde.org> Date: Tue, 19 Nov 2002 10:44:02 +0100 Message-ID: <17355.1037699042@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20021119184410.D29957-100000@gamplex.bde.org>, Bruce Evans writes: >On Tue, 19 Nov 2002, Tim Robbins wrote: > >> I'm glad you brought this up... I'd like to see /dev/devctl made mode 600 >> instead of 644 because it does not look very robust and because only one >> devctl can be open at a time. >> >> The two other security/reliability bugs I can see are that the async >> (ioctl FIOASYNC) and non-blocking (ioctl FIONBIO) flags are not cleared >> between when one process closes the device and another opens it. Leaving > >Per-device flags for these ioctls are a pet peeve of mine. This is one of the things which are much easier to fix if we move devices from the vnode layer to the fdesc layer. A move which increasingly is pressing its way up my TODO list. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message