From owner-freebsd-bugs Sun Oct 12 13:50:45 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id NAA15299 for bugs-outgoing; Sun, 12 Oct 1997 13:50:45 -0700 (PDT) (envelope-from owner-freebsd-bugs) Received: from innocence.interface-business.de (innocence.interface-business.de [193.101.57.202]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id NAA15288 for ; Sun, 12 Oct 1997 13:50:32 -0700 (PDT) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by innocence.interface-business.de (8.6.11/8.6.9) with UUCP id WAA18540; Sun, 12 Oct 1997 22:50:17 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.8.7/8.8.5) id WAA13565; Sun, 12 Oct 1997 22:38:15 +0200 (MET DST) Message-ID: <19971012223814.MI27564@uriah.heep.sax.de> Date: Sun, 12 Oct 1997 22:38:14 +0200 From: j@uriah.heep.sax.de (J Wunsch) To: volf@oasis.IAEhv.nl (Frank Volf) Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: bin/4303 References: <199710121359.GAA06950@freefall.freebsd.org> <199710121523.PAA07458@oasis.IAEhv.nl> X-Mailer: Mutt 0.60_p2-3,5,8-9 Mime-Version: 1.0 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199710121523.PAA07458@oasis.IAEhv.nl>; from Frank Volf on Oct 12, 1997 17:23:25 +0200 Sender: owner-freebsd-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Frank Volf wrote: > I completely disagree: if I set dumpon to a non swap device by accident, > (for example /dev/rsd0s1e) I could/will lose part of my file system. dumpon should perhaps issue a warning if the device looks like something that has a filesystem on it. It should refuse to dump to any device that was opened by the time the dump happens. > But that is not the point. In kern_shutdown.c the following code can be > found (arround line 320 in function dumpsys): > > if ((minor(dumpdev)&07) != 1) > return; This used to be an (undocumented) feature, but turned into a bug over time. A device with (minor & 07) == 1 is no longer something very special. Swapping could have happened to anything else, nor would it make much sense that you could dump to /dev/rfd0.1720 but not to any other floppy device. ;-) Let alone tape drives... > Please, reconsider the close on this ticket. Well, i didn't say that everything is OK with the current behaviour either: it's only that i don't think we should restrict it to swap partions only. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)