From owner-freebsd-arch@FreeBSD.ORG Wed May 20 16:27:57 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB7791065706; Wed, 20 May 2009 16:27:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 998118FC19; Wed, 20 May 2009 16:27:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id n4KGQ2fV057277; Wed, 20 May 2009 10:26:02 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 20 May 2009 10:26:12 -0600 (MDT) Message-Id: <20090520.102612.-1795528612.imp@bsdimp.com> To: jhb@freebsd.org From: "M. Warner Losh" In-Reply-To: <200905201124.24747.jhb@freebsd.org> References: <200905121020.18497.jhb@freebsd.org> <20090520.085924.-1935226744.imp@bsdimp.com> <200905201124.24747.jhb@freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@freebsd.org Subject: Re: Remove d_thread_t for 8.0 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2009 16:27:58 -0000 In message: <200905201124.24747.jhb@freebsd.org> John Baldwin writes: : On Wednesday 20 May 2009 10:59:24 am M. Warner Losh wrote: : > In message: <200905121020.18497.jhb@freebsd.org> : > John Baldwin writes: : > : In the same vein as purging BURN_BRIDGES stuff, is there any objection to : > : removing d_thread_t from 8.0? It is intended as a compat shim to reduce : > : diffs with 4.x. However, at this point drivers are not actively being : merged : > : back to 4.x, so I think it is no longer necessary. : > : > It was also intended to allow easier sharing for folks that were using : > FreeBSD 4.x, 5.x, etc. I know that at least one user still has some : > 4.x deployments, but I suspect that they are otherwise off 4.x so it : > might not be a problem for them. It would be yet another thing to : > change when going from 7.x to 8.x for them... : > : > We certainly should remove it from the drivers in the tree for 8.0. : > Right now it is used in about a two dozen places. : : Even in a shared driver I believe the function prototypes for devsw routines : would already have to be #ifdef'd due to the 'dev_t' -> 'struct cdev *' : change which does have a similar foo_t typedef to ease the transition. Given : that, any code compiled for 7.0+ is already using a function prototype that : is not compatible with 4.x and there isn't a need for it to use d_thread_t. : They can just use 'struct thread *' always when using 'struct cdev *'. Yes. Let's eliminate it from the tree, and then talk about removing it from conf.h :) There's other ways to paper over those issues, and I know that they are relatively small in header files. But those headers are likely beyond the scope of what the project has to support.. Warner