From owner-freebsd-current@FreeBSD.ORG Mon Mar 25 20:44:15 2013 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B0DDCE00; Mon, 25 Mar 2013 20:44:15 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C0E1EF77; Mon, 25 Mar 2013 20:44:14 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA28554; Mon, 25 Mar 2013 22:44:13 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1UKEFZ-000PDL-4Y; Mon, 25 Mar 2013 22:44:13 +0200 Message-ID: <5150B71B.6060106@FreeBSD.org> Date: Mon, 25 Mar 2013 22:44:11 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130321 Thunderbird/17.0.4 MIME-Version: 1.0 To: FreeBSD Current , freebsd-hackers@FreeBSD.org Subject: Fwd: kern/122838: [devfs] devfs doesn't handle complex paths (like zvol/pool/vms) good References: <5150B598.7050700@FreeBSD.org> In-Reply-To: <5150B598.7050700@FreeBSD.org> X-Enigmail-Version: 1.5.1 X-Forwarded-Message-Id: <5150B598.7050700@FreeBSD.org> Content-Type: text/plain; charset=x-viet-vps Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 20:44:15 -0000 Would like to ask for opinions on this topic... Please read this PR for context: http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/122838 Especially Jaakko's insightful description of the problem. -------- Original Message -------- Message-ID: <5150B598.7050700@FreeBSD.org> Date: Mon, 25 Mar 2013 22:37:44 +0200 From: Andriy Gapon Subject: Re: kern/122838: [devfs] devfs doesn't handle complex paths (like zvol/pool/vms) good Can't believe that we are still where we were more than two years ago... I think that we have to make this change even if it _might_ break some existing rulesets. Rationale: - current behavior is contrary to any documentation - current behavior is contrary to common sense - current behavior is very hard to describe and account for - I presume that very few people actually fully understand the current behavior - I presume that even fewer people made a conscious choice to depend or make use of its non-trivial features of the current behavior So, we should make the behavior of devfs pattern consistent with the documentation and the common sense. In addition to Jaakko's patch I propose that we pass FNM_PATHNAME to fnmatch(9), so that the matching is indeed consistent with glob(3) / shell glob-ing rules for filesystem paths. -- Andriy Gapon