From owner-freebsd-arm@FreeBSD.ORG  Thu Mar 12 20:15:21 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id BE784F5
 for <freebsd-arm@freebsd.org>; Thu, 12 Mar 2015 20:15:21 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E81737E
 for <freebsd-arm@freebsd.org>; Thu, 12 Mar 2015 20:15:21 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t2CKFLjT068354
 for <freebsd-arm@freebsd.org>; Thu, 12 Mar 2015 20:15:21 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t2CKFLKn068353;
 Thu, 12 Mar 2015 20:15:21 GMT (envelope-from root)
Date: Thu, 12 Mar 2015 20:15:21 +0000
To: freebsd-arm@freebsd.org
From: "imp (Warner Losh)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2018: Introduce Annapurna Labs AHCI
 support
Message-ID: <a1e2898622f2f53d15bca79909a6477e@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2018: Introduce Annapurna Labs AHCI support
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-tmsdq7z6rym2k7agm3fv>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-wqysm6qikfri2awpdmpj>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-lp4daqpuzz2y5vyrxipd-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-lp4daqpuzz2y5vyrxipd-req@FreeBSD.org>
Thread-Index: ZGMxZTcyZjQyYTA3MjQzZjU5NjlmODc0YTQ5IFUB89k=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2015 20:15:21 -0000

imp added inline comments.

INLINE COMMENTS
  sys/dev/ahci/ahci.c:150-153 We should document this then. Add a comment that states that some platforms, specifically BLAH, require writing to this read-only register so a quirk is provided to update them and prevent writing to standard conforming devices. This way we know we can eliminate it if it turns out that the current root-cause analysis proves to be inaccurate or better worked around.
  sys/dev/ahci/ahci.c:199-201 I'd add a comment here as well so we know why we do this weird, odd-ball thing. It will also help reduce the temptation to cut and paste it for devices that clearly don't need it.

REVISION DETAIL
  https://reviews.freebsd.org/D2018

To: zbb, mav, imp, smh
Cc: freebsd-arm