Date: Fri, 12 Oct 2018 23:36:23 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Sean Bruno <sbruno@freebsd.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, Tobias Kortkamp <tobik@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r481915 - in head/sysutils/ipmitool: . files Message-ID: <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc> In-Reply-To: <7010c7ad-24a6-fadd-ae7e-8623d827e066@freebsd.org> References: <201810121751.w9CHpbfM070987@repo.freebsd.org> <1539367083.328758.1540102872.2C88E8B9@webmail.messagingengine.com> <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org> <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> <7010c7ad-24a6-fadd-ae7e-8623d827e066@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dwbttirdxekzoosf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 12, 2018 at 02:55:38PM -0600, Sean Bruno wrote: >=20 >=20 > On 10/12/18 2:10 PM, Mathieu Arnold wrote: > > So, you want us to add something like "if the variable EXTRA_PATCHES is > > already set before, instead of using =3D, use +=3D"? > >=20 > > I don't really see it happening, we are not going to state all the > > possible cases, the porter's handbook would end up being ISO9001 and 50k > > pages long, we assume that you know make(1), so that when you add a > > variable, you actually look for it in the Makefile to see if it is not > > already set. >=20 > I don't think I'm asking for that. >=20 > I think I'm asking for "we should have the example be a +=3D instead of a > =3D" because of the DOCS variable and how it behaves. EXTRA_PATCHES > wasn't in use in this example before I added the openssl1.1.1 patch > abomination, but I guess, DOCS implicitly means its always in use. The example is GENERIC. THIS port has a DOCS option that sets EXTRA_PATCHES. --=20 Mathieu Arnold --dwbttirdxekzoosf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlvBE9dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkitqQ/9EU5byBVICxipjnkmbhxg+fqLVIvNFTZHlXep8r8hO0s20JLKzOZol9Xo X0q7ZIZnMxjCk3t0zUp2pICrZQK7aMJlpihf6TRM3BFM28lgUKMO5YeLlDiSxkpB CbXfxVoDZ8eByzOtsFH9lpmmGqw7B5OX0xgbnuOUPah1f3Zn3Acb8Skb7U8UR/Fw r8ERuJ5CI1sfITvdEWHlIsa+gBR2x9gkRX+UT8+jfLI9LJdglBKiTK8Y+nFHkxGW dtAvPtgoNerWZ5QOqgwQSvJnSKojkyZKh8sdb+Gq2aftvs3DYxBPKNbKEnX41b0U 6JGOU8ViedjoJjHelgWvPSe4tk/SNZbdcjxsNMrrOWKx3JzF34JHh0sW3A8Iwhci DWiAJLYKs+dfPwTL+U3kbLQRuWYjGxTA1Fqq9F+eJwJGIP/+t9HMiSfikmzzsHqR rWSG/SVyPYJWsPILjdbIEZPuC4CQDlzEuK6BE2/yxa1dHXG9EOAQpKLyA+OpA0cy DL9DFHTQ2cQnfVGaWA/z7Os76QQd3pjsjHCPHneN+1Ch+8pJiMmqLcr6TSckl3iw EwItcsuxq14R/5uLUyPNdTGbHES2sZL+2Ll6cK9gubHSaKL/2zpKWvcS4jPgg4PG XIxmj4nHmL/N9DwjOXRHbDrfKJ3tazzyOd0D2KCwmh9bB4wLDWY= =KIda -----END PGP SIGNATURE----- --dwbttirdxekzoosf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181012213623.54l4p6e5debtflru>