From owner-freebsd-hackers@FreeBSD.ORG  Sun Jun 22 20:34:03 2003
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B3AFA37B401
	for <freebsd-hackers@freebsd.org>;
	Sun, 22 Jun 2003 20:34:03 -0700 (PDT)
Received: from smtp8.Stanford.EDU (smtp8.Stanford.EDU [171.67.16.35])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3689143F75
	for <freebsd-hackers@freebsd.org>;
	Sun, 22 Jun 2003 20:34:03 -0700 (PDT)
	(envelope-from tedu@stanford.edu)
Received: (from root@localhost)
	by smtp8.Stanford.EDU (8.12.9/8.12.9) id h5N3Y24o010301
	for freebsd-hackers@freebsd.org; Sun, 22 Jun 2003 20:34:02 -0700 (PDT)
Received: from elaine32.Stanford.EDU (elaine32.Stanford.EDU [171.64.15.107])
	by smtp8.Stanford.EDU (8.12.9/8.12.9) with ESMTP id h5N3XwcU010291;
	Sun, 22 Jun 2003 20:33:59 -0700 (PDT)
Date: Sun, 22 Jun 2003 20:33:58 -0700 (PDT)
From: Ted Unangst <tedu@stanford.edu>
To: Sean Farley <sean-freebsd@farley.org>
In-Reply-To: <20030621103502.K18572@thor.farley.org>
Message-ID: <Pine.GSO.4.44.0306222024560.1993-100000@elaine32.Stanford.EDU>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-hackers@freebsd.org
Subject: Re: Replacing GNU grep revisited
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jun 2003 03:34:04 -0000

your handling of -i at least is incorrect.  after patching, i get very
wrong results.  results vary depending on length of string.

reuelos:/tmp/grep-0.16> ./grep -i fastgrep *
grep.c:fastgrep_t       *fg_pattern;

reuelos:/tmp/grep-0.16> ./grep fastgrep *
grep.c:fastgrep_t       *fg_pattern;
grep.h:} fastgrep_t;
grep.h:extern fastgrep_t        *fg_pattern;
grep.h:int               fastcomp(fastgrep_t *fg, const char *pattern);
util.c:static int       grep_search(fastgrep_t *fg, unsigned char *data,
int dataLen);
util.c:int fastcomp(fastgrep_t *fg,
util.c:static int grep_search(fastgrep_t *fg,


-- 
"I am making this trip to Africa because Washington is an international
city, just like Tokyo, Nigeria or Israel.  As mayor, I am an
international symbol.  Can you deny that to Africa?"
      - M. Barry, Mayor of Washington, DC