From owner-freebsd-bugs@FreeBSD.ORG Tue Apr 4 00:10:24 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F320216A423 for ; Tue, 4 Apr 2006 00:10:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 46A1243D55 for ; Tue, 4 Apr 2006 00:10:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k340AIo6063736 for ; Tue, 4 Apr 2006 00:10:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k340AIcR063718; Tue, 4 Apr 2006 00:10:18 GMT (envelope-from gnats) Resent-Date: Tue, 4 Apr 2006 00:10:18 GMT Resent-Message-Id: <200604040010.k340AIcR063718@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Charles Hardin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B70A516A41F for ; Tue, 4 Apr 2006 00:09:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 265C943D78 for ; Tue, 4 Apr 2006 00:09:05 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k34094sT031666 for ; Tue, 4 Apr 2006 00:09:04 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k34094H8031664; Tue, 4 Apr 2006 00:09:04 GMT (envelope-from nobody) Message-Id: <200604040009.k34094H8031664@www.freebsd.org> Date: Tue, 4 Apr 2006 00:09:04 GMT From: Charles Hardin To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: bin/95292: A minor nit in rm.c to do an fts_close before returning from rm_tree X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 00:10:24 -0000 >Number: 95292 >Category: bin >Synopsis: A minor nit in rm.c to do an fts_close before returning from rm_tree >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Apr 04 00:10:17 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Charles Hardin >Release: CURRENT from cvs >Organization: >Environment: >Description: Just doing a code review and noticed there wasn't an fts_close in the rm_tree function in rm.c. This seems trivial, except another developer cut and pasted the code and introduced an fd leak as a result into another application. So, this isn't really a bug, bug... Just a suggestion... >How-To-Repeat: >Fix: Index: rm.c =================================================================== RCS file: /home/ncvs/src/bin/rm/rm.c,v retrieving revision 1.53 diff -u -r1.53 rm.c --- rm.c 29 Sep 2005 20:40:29 -0000 1.53 +++ rm.c 4 Apr 2006 00:01:53 -0000 @@ -307,6 +307,7 @@ } if (errno) err(1, "fts_read"); + fts_close(fts); } void >Release-Note: >Audit-Trail: >Unformatted: