Date: Sun, 3 Jul 2011 14:07:59 +0200 From: Robert Millan <rmh@debian.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-hackers@freebsd.org, Ed Maste <emaste@freebsd.org> Subject: Re: [PATCH] PAGE_SIZE in libsbuf Message-ID: <CAOfDtXNQD1yVv0NFxeSRiS07BoQA3L-7vwJ0kLJwnOfABWP4Gg@mail.gmail.com> In-Reply-To: <20110703115750.GL48734@deviant.kiev.zoral.com.ua> References: <CAOfDtXMVWT0jGw_o5ugBNW7Fiq1O2avDnprXAZ3s8aP-hsMTLA@mail.gmail.com> <20110703115750.GL48734@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/7/3 Kostik Belousov <kostikbel@gmail.com>: > I think the different workaround is already included in the latest > sbuf source. Please see > http://svnweb.freebsd.org/base/head/sys/kern/subr_sbuf.c?revision=222015&view=markup How does libsbuf react if the guess fails? Also note this codepath isn't tested in FreeBSD (except for pc98). I'm afraid this situation could lead to runtime errors somehow. I'd still propose replacing this guess with a sysconf() check. -- Robert Millan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXNQD1yVv0NFxeSRiS07BoQA3L-7vwJ0kLJwnOfABWP4Gg>